fixed miscellaneous Warnings & Messages

andres-garcia-alves · Jun 30, 2023 · f6f90d6 · f6f90d6
1 parent abbd4a8
commit f6f90d6
Show file tree

Hide file tree

Showing 25 changed files with 195 additions and 159 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -0,0 +1,79 @@
+[*.cs]
+
+# IDE1006: Naming Styles
+dotnet_diagnostic.IDE1006.severity = none
+csharp_indent_labels = no_change
+csharp_using_directive_placement = outside_namespace:silent
+csharp_prefer_simple_using_statement = true:suggestion
+csharp_prefer_braces = true:silent
+csharp_style_namespace_declarations = block_scoped:silent
+csharp_style_prefer_method_group_conversion = true:silent
+csharp_style_prefer_top_level_statements = true:silent
+csharp_style_expression_bodied_methods = false:silent
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_operators = false:silent
+csharp_style_expression_bodied_properties = true:silent
+csharp_style_expression_bodied_indexers = true:silent
+csharp_style_expression_bodied_accessors = true:silent
+csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_local_functions = false:silent
+
+[*.{cs,vb}]
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+tab_width = 4
+indent_size = 4
+end_of_line = crlf
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
+dotnet_style_prefer_auto_properties = true:silent
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
+dotnet_style_prefer_conditional_expression_over_assignment = true:silent
diff --git a/Renamer.Engine/Entities/NamingProcessedEventArgs.cs b/Renamer.Engine/Entities/NamingProcessedEventArgs.cs
@@ -8,8 +8,6 @@ public class NamingProcessedEventArgs : EventArgs
         public NamingResult NamingResult { get; set; }
         public int Progress { get; set; }
 
-        public NamingProcessedEventArgs() { }
-
         public NamingProcessedEventArgs(Operation operation, NamingResult namingResult, int progress)
         {
             this.Operation = operation;

diff --git a/Renamer.Engine/Entities/NamingRequest.cs b/Renamer.Engine/Entities/NamingRequest.cs
@@ -5,8 +5,6 @@ public class NamingRequest
         public ObjectType ObjectType { get; }
         public string CurrentName { get; }
 
-        public NamingRequest() { }
-
         public NamingRequest(ObjectType objectType, string currentName)
         {
             this.ObjectType = objectType;

diff --git a/Renamer.Engine/Entities/RenameEngineValidator.cs b/Renamer.Engine/Entities/RenameEngineValidator.cs
@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-
-using Renamer.Engine.Helpers;
+using Renamer.Engine.Helpers;
 
 namespace Renamer.Engine.Entities
 {
@@ -39,7 +36,7 @@ public void Validate()
                     case RenameType.Unknown:            throw new ArgumentException("No rename method selected.");
                 }
             }
-            catch (Exception ex) { throw ex; }
+            catch (Exception) { throw; }
         }
 
         private void ValidateBySimpleMatch()

diff --git a/Renamer.Engine/Entities/RenameSettings.cs b/Renamer.Engine/Entities/RenameSettings.cs
@@ -1,14 +1,15 @@
-using System;
-using System.Collections.Generic;
-
-namespace Renamer.Engine.Entities
+namespace Renamer.Engine.Entities
 {
     public class RenameSettings
     {
         public RenameType RenameType { get; }
         public List<string> Parameters { get; }
         public bool IncludeExtension { get; }
 
+        public RenameSettings(RenameType renameType) : this(renameType, new List<string>(), default)
+        {
+        }
+
         public RenameSettings(RenameType renameType, List<string> parameters, bool includeExtension = false)
         {
             // if (parameters == null) { throw new ArgumentNullException(nameof(parameters)); }

diff --git a/Renamer.Engine/Entities/RenameSettingsFactory.cs b/Renamer.Engine/Entities/RenameSettingsFactory.cs
@@ -6,67 +6,67 @@ public class RenameSettingsFactory
     {
         public static RenameSettings SentenceCase(bool includeExtension)
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.SentenceCase, parameters, includeExtension);
         }
 
         public static RenameSettings TitleCase(bool includeExtension)
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.TitleCase, parameters, includeExtension);
         }
 
         public static RenameSettings UpperCase(bool includeExtension)
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.UpperCase, parameters, includeExtension);
         }
 
         public static RenameSettings LowerCase(bool includeExtension)
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.LowerCase, parameters, includeExtension);
         }
 
         public static RenameSettings InvertedCase(bool includeExtension)
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.InvertedCase, parameters, includeExtension);
         }
 
         public static RenameSettings RemoveTildes(bool includeExtension)
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.RemoveTildes, parameters, includeExtension);
         }
 
         public static RenameSettings BySimpleMatch(string matchSearch, string matchRemplacement, bool includeExtension)
         {
-            List<string> parameters = new List<string>() { matchSearch, matchRemplacement };
+            var parameters = new List<string>() { matchSearch, matchRemplacement };
             return new RenameSettings(RenameType.BySimpleMatch, parameters, includeExtension);
         }
 
         public static RenameSettings ByPattern(string beginnigText, string startIndex, string increment, string numericPad, bool includeExtension)
         {
-            List<string> parameters = new List<string>() { beginnigText, startIndex, increment, numericPad };
+            var parameters = new List<string>() { beginnigText, startIndex, increment, numericPad };
             return new RenameSettings(RenameType.ByPattern, parameters, includeExtension);
         }
 
         public static RenameSettings PositionalReplace(string positionalReplaceIndex, string positionalReplaceText, bool includeExtension)
         {
-            List<string> parameters = new List<string>() { positionalReplaceIndex, positionalReplaceText };
+            var parameters = new List<string>() { positionalReplaceIndex, positionalReplaceText };
             return new RenameSettings(RenameType.PositionalReplace, parameters, includeExtension);
         }
 
         public static RenameSettings PositionalAppend(string positionalAppendIndex, string positionalAppendText, bool includeExtension)
         {
-            List<string> parameters = new List<string>() { positionalAppendIndex, positionalAppendText };
+            var parameters = new List<string>() { positionalAppendIndex, positionalAppendText };
             return new RenameSettings(RenameType.PositionalAppend, parameters, includeExtension);
         }
 
         public static RenameSettings Unknown()
         {
-            List<string> parameters = new List<string>();
+            var parameters = new List<string>();
             return new RenameSettings(RenameType.Unknown, parameters, false);
         }
     }

diff --git a/Renamer.Engine/GlobalSuppressions.cs b/Renamer.Engine/GlobalSuppressions.cs
@@ -6,3 +6,9 @@
 using System.Diagnostics.CodeAnalysis;
 
 [assembly: SuppressMessage("Style", "IDE0016:Use 'throw' expression", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.Entities.RenameSettings.#ctor(Renamer.Engine.RenameType,System.Collections.Generic.List{System.String},System.Boolean)")]
+[assembly: SuppressMessage("Style", "IDE0057:Use range operator", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.Helpers.ExtensionMethods.Truncate(System.String,System.Int32)~System.String")]
+[assembly: SuppressMessage("Style", "IDE0057:Use range operator", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.NamingPatterns.PositionalAppendNaming.Process(Renamer.Engine.ObjectType,System.String)~System.String")]
+[assembly: SuppressMessage("Style", "IDE0057:Use range operator", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.NamingPatterns.PositionalReplaceNaming.Process(Renamer.Engine.ObjectType,System.String)~System.String")]
+[assembly: SuppressMessage("Style", "IDE0057:Use range operator", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.NamingPatterns.SentenceCaseNaming.Process(Renamer.Engine.ObjectType,System.String)~System.String")]
+[assembly: SuppressMessage("Style", "IDE0057:Use range operator", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.NamingPatterns.TitleCaseNaming.Process(Renamer.Engine.ObjectType,System.String)~System.String")]
+[assembly: SuppressMessage("Style", "IDE0066:Convert switch statement to expression", Justification = "<Pending>", Scope = "member", Target = "~M:Renamer.Engine.RenameEngine.GetNamingPattern(Renamer.Engine.PhysicalRenamer.IRenamer,Renamer.Engine.Entities.RenameSettings)~Renamer.Engine.NamingPatterns.BaseNaming")]
diff --git a/Renamer.Engine/Helpers/ExtensionMethods.cs b/Renamer.Engine/Helpers/ExtensionMethods.cs
@@ -1,6 +1,4 @@
-using System;
-
-namespace Renamer.Engine.Helpers
+namespace Renamer.Engine.Helpers
 {
     internal static class ExtensionMethods
     {
@@ -34,9 +32,9 @@ public static bool IsNumeric(this string text, bool zeroIsValid)
         /// <returns>Returns true if the text is a valid filename, otherwise false.</returns>
         public static bool IsValidFileName(this string text)
         {
-            if (text.Contains("\\") || text.Contains("/") || text.Contains(":") ||
-                text.Contains("*") || text.Contains("?") || text.Contains("\"") ||
-                text.Contains("<") || text.Contains(">") || text.Contains("|"))
+            if (text.Contains('\\') || text.Contains('/') || text.Contains(':') ||
+                text.Contains('*') || text.Contains('?') || text.Contains('"') ||
+                text.Contains('<') || text.Contains('>') || text.Contains('|'))
                 return false;
 
             return true;

diff --git a/Renamer.Engine/NamingPatterns/ByPatternNaming.cs b/Renamer.Engine/NamingPatterns/ByPatternNaming.cs
@@ -1,8 +1,4 @@
-using System;
-using System.IO;
-using System.Threading.Tasks;
-
-using Renamer.Engine.Entities;
+using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
 
 namespace Renamer.Engine.NamingPatterns
@@ -55,7 +51,7 @@ protected override string Process(ObjectType objectType, string currentName)
             // increase currentIndex for next time
             currentIndex += increment;
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }

diff --git a/Renamer.Engine/NamingPatterns/BySimpleMatchNaming.cs b/Renamer.Engine/NamingPatterns/BySimpleMatchNaming.cs
@@ -1,8 +1,4 @@
-using System;
-using System.IO;
-using System.Threading.Tasks;
-
-using Renamer.Engine.Entities;
+using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
 
 namespace Renamer.Engine.NamingPatterns
@@ -44,7 +40,7 @@ protected override string Process(ObjectType objectType, string currentName)
                 str += Path.GetExtension(currentName);
             }
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }

diff --git a/Renamer.Engine/NamingPatterns/InvertedCaseNaming.cs b/Renamer.Engine/NamingPatterns/InvertedCaseNaming.cs
@@ -1,7 +1,4 @@
-using System;
-using System.IO;
-using System.Text;
-using System.Threading.Tasks;
+using System.Text;
 
 using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
@@ -35,7 +32,7 @@ protected override string Process(ObjectType objectType, string currentName)
         {
             string str;
             char[] characters;
-            StringBuilder sb = new StringBuilder();
+            var sb = new StringBuilder();
 
             if (base.RenameSettings.IncludeExtension && Path.GetExtension(currentName) != String.Empty)
             {
@@ -62,7 +59,7 @@ protected override string Process(ObjectType objectType, string currentName)
                 str = sb.ToString() + Path.GetExtension(currentName);
             }
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }

diff --git a/Renamer.Engine/NamingPatterns/LowerCaseNaming.cs b/Renamer.Engine/NamingPatterns/LowerCaseNaming.cs
@@ -1,8 +1,4 @@
-using System;
-using System.IO;
-using System.Threading.Tasks;
-
-using Renamer.Engine.Entities;
+using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
 
 namespace Renamer.Engine.NamingPatterns
@@ -46,7 +42,7 @@ protected override string Process(ObjectType objectType, string currentName)
                 str += Path.GetExtension(currentName);
             }
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }

diff --git a/Renamer.Engine/NamingPatterns/PositionalAppendNaming.cs b/Renamer.Engine/NamingPatterns/PositionalAppendNaming.cs
@@ -1,8 +1,4 @@
-using System;
-using System.IO;
-using System.Threading.Tasks;
-
-using Renamer.Engine.Entities;
+using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
 
 namespace Renamer.Engine.NamingPatterns
@@ -61,7 +57,7 @@ protected override string Process(ObjectType objectType, string currentName)
                 }
             }
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }

diff --git a/Renamer.Engine/NamingPatterns/PositionalReplaceNaming.cs b/Renamer.Engine/NamingPatterns/PositionalReplaceNaming.cs
@@ -1,8 +1,4 @@
-using System;
-using System.IO;
-using System.Threading.Tasks;
-
-using Renamer.Engine.Entities;
+using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
 
 namespace Renamer.Engine.NamingPatterns
@@ -61,7 +57,7 @@ protected override string Process(ObjectType objectType, string currentName)
                 }
             }
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }

diff --git a/Renamer.Engine/NamingPatterns/RemoveTildesNaming.cs b/Renamer.Engine/NamingPatterns/RemoveTildesNaming.cs
@@ -1,8 +1,4 @@
-using System;
-using System.IO;
-using System.Threading.Tasks;
-
-using Renamer.Engine.Entities;
+using Renamer.Engine.Entities;
 using Renamer.Engine.PhysicalRenamer;
 
 namespace Renamer.Engine.NamingPatterns
@@ -48,7 +44,7 @@ protected override string Process(ObjectType objectType, string currentName)
                 str += Path.GetExtension(currentName);
             }
 
-            string basePath = Path.GetDirectoryName(currentName);
+            string basePath = Path.GetDirectoryName(currentName) ?? "";
             return Path.Combine(basePath, str);
         }
     }