-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for conan lock v2 #2461
Add support for conan lock v2 #2461
Conversation
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
The change suggested addes the Do we want to reuse the same metadata structure or define another? |
We should add another similar to what you have done. However, I think we should still make a breaking change:
this implies a breaking update to the JSON schema. |
Signed-off-by: houdini91 <mdstrauss91@gmail.com>
@wagoodman @tgerla i think i have addressed your comments. |
@houdini91 to regenerate the JSON schema:
the docs about this is here I can get this across the finish line today 👍 |
I rebased and made some alterations to help get tests passing, however, I don't have write access. I'll merge this as-is into a feature branch in the repo and get it reviewed in a separate PR (you'll still have attribution in the changelog and this PR 👍 ). |
* conan lock 2.x requires field support Signed-off-by: houdini91 <mdstrauss91@gmail.com> * PR review, struct renaming Signed-off-by: houdini91 <mdstrauss91@gmail.com> --------- Signed-off-by: houdini91 <mdstrauss91@gmail.com>
* Add support for conan lock v2 (#2461) * conan lock 2.x requires field support Signed-off-by: houdini91 <mdstrauss91@gmail.com> * PR review, struct renaming Signed-off-by: houdini91 <mdstrauss91@gmail.com> --------- Signed-off-by: houdini91 <mdstrauss91@gmail.com> * decompose conanlock parser + add tests Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: houdini91 <mdstrauss91@gmail.com> Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> Co-authored-by: mikey strauss <mdstrauss91@gmail.com>
* Add support for conan lock v2 (anchore#2461) * conan lock 2.x requires field support Signed-off-by: houdini91 <mdstrauss91@gmail.com> * PR review, struct renaming Signed-off-by: houdini91 <mdstrauss91@gmail.com> --------- Signed-off-by: houdini91 <mdstrauss91@gmail.com> * decompose conanlock parser + add tests Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> --------- Signed-off-by: houdini91 <mdstrauss91@gmail.com> Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com> Co-authored-by: mikey strauss <mdstrauss91@gmail.com>
In conan 2.x i see there is a
requries
field listing the packages instead of thegraph_lock
.For spec change details see https://github.com/conan-io/tribe/blob/main/design/034-new_lockfiles.md. and https://docs.conan.io/2/tutorial/versioning/lockfiles.html#tutorial-versioning-lockfiles.
Closes #2050
Closes #2462