Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support casting for most types #54

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: Support casting for most types #54

merged 1 commit into from
Sep 27, 2024

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Support casting to/from most of the OQ3 types, not just bool

Testing done: Unit tests passed locally

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner September 26, 2024 21:51
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (890698b) to head (03b2574).
Report is 1 commits behind head on ksh/no_ixs.

Additional details and impacted files
@@             Coverage Diff             @@
##           ksh/no_ixs      #54   +/-   ##
===========================================
  Coverage       98.86%   98.87%           
===========================================
  Files              23       23           
  Lines            3444     3455   +11     
===========================================
+ Hits             3405     3416   +11     
  Misses             39       39           
Flag Coverage Δ
98.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws kshyatt-aws merged commit e009628 into ksh/no_ixs Sep 27, 2024
12 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/cast branch September 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant