GOVUKAPP-630 Clear visited Items #113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ov/govuk-mobile-ios-app into feature/recent-activity-clear-all
|
batesyuk
requested changes
Oct 10, 2024
| @@ -76,6 +76,13 @@ extension AppEvent { | |||
| ) | |||
| } | |||
|
|
|||
| static func clearRecentActivity() -> AppEvent { | |||
| .init( | |||
| name: "Cleared_recent_activity", | |||
There was a problem hiding this comment.
This doesn't seem to match the other name formats for AppEvent?
| "recentActivityNavigationTitle" | ||
| ) | ||
| func deleteActivities() { | ||
| for item in model.todaysActivites { |
There was a problem hiding this comment.
This should be done in the ActivityService -> ActivityRepository
It should also really be done on the background context.
| } | ||
| model.todaysActivites.removeAll() | ||
| model.currentMonthActivities.removeAll() | ||
| model.recentMonthActivities.removeAll() |
There was a problem hiding this comment.
What would happen here if a previous save failed?
There was a problem hiding this comment.
Looks like snapshots are potentially wrong here... plenty of snapshots here that shouldn't have changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds clear all functionality to the recent activity view