Fixed some warnings :)

alexvcasillas · May 30, 2017 · 668a305 · 668a305
1 parent 9a4cb3b
commit 668a305
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 21 deletions.
diff --git a/examples/mobx-state-tree-github-repos-demo/src/components/header/header.jsx b/examples/mobx-state-tree-github-repos-demo/src/components/header/header.jsx
@@ -1,37 +1,41 @@
-import React from "react";
-import { inject, observer } from "mobx-react";
+import React from 'react';
+import { inject, observer } from 'mobx-react';
 
-import Language from "../language/language";
+import Language from '../language/language';
 
-import "./stylesheets/header.css";
+import './stylesheets/header.css';
 
 const Header = ({ language }) => (
   <div id="Header">
     <div className="language-settings">
       <div
         className={
-          language.currentLanguage === "es" ? "element current" : "element"
+          language.currentLanguage === 'es' ? 'element current' : 'element'
         }
-        onClick={() => language.changeLanguageTo("es")}
+        onClick={() => language.changeLanguageTo('es')}
       >
         <Language resource="CHANGE_SPANISH" />
       </div>
       <div
         className={
-          language.currentLanguage === "en" ? "element current" : "element"
+          language.currentLanguage === 'en' ? 'element current' : 'element'
         }
-        onClick={() => language.changeLanguageTo("en")}
+        onClick={() => language.changeLanguageTo('en')}
       >
         <Language resource="CHANGE_ENGLISH" />
       </div>
     </div>
     <div className="right-section">
       <Language resource="WITH_LOVE" />
-      <a target="_blank" href="https://github.com/alexvcasillas">
+      <a
+        target="_blank"
+        rel="noopener noreferrer"
+        href="https://github.com/alexvcasillas"
+      >
         @alexvcasillas
       </a>
     </div>
   </div>
 );
 
-export default inject("language")(observer(Header));
+export default inject('language')(observer(Header));
diff --git a/examples/mobx-state-tree-github-repos-demo/src/components/user-card/user-card.jsx b/examples/mobx-state-tree-github-repos-demo/src/components/user-card/user-card.jsx
@@ -1,14 +1,14 @@
-import React from "react";
+import React from 'react';
 
-import Language from "../language/language";
+import Language from '../language/language';
 
-import "./stylesheets/user-card.css";
+import './stylesheets/user-card.css';
 
 const UserCard = ({ user }) => (
   <div id="UserCard">
     <div className="content">
       <div className="user-avatar">
-        <img src={user.avatar} role="presentation" />
+        <img src={user.avatar} alt={user.name ? user.name : 'No name'} />
       </div>
       <div className="user-info">
         <div className="row user-name">

diff --git a/examples/mobx-state-tree-github-repos-demo/src/stores/github.js b/examples/mobx-state-tree-github-repos-demo/src/stores/github.js
@@ -1,11 +1,11 @@
-import fetch from "node-fetch";
-import { types } from "mobx-state-tree";
+import fetch from 'node-fetch';
+import { types } from 'mobx-state-tree';
 
-const GithubClientId = "my_client_id";
-const GithubSecretId = "my_secret_id";
+const GithubClientId = 'my_client_id';
+const GithubSecretId = 'my_secret_id';
 
 const UserModel = types.model(
-  "UserModel",
+  'UserModel',
   {
     name: types.maybe(types.string),
     bio: types.maybe(types.string),
@@ -15,9 +15,9 @@ const UserModel = types.model(
 );
 
 const GithubStore = types.model(
-  "GithubStore",
+  'GithubStore',
   {
-    searchName: types.optional(types.string, ""),
+    searchName: types.optional(types.string, ''),
     user: types.optional(types.maybe(UserModel), null), // Object with all the user data that comes from the Github API Fetch
     repos: types.optional(types.array(types.frozen), []), // Array of Repositories that comes from the Github API Fetch
     fetchingData: types.optional(types.boolean, false)