Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl OPENSSL_SRC_PREFIX_SANTIZE env var #165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

impl OPENSSL_SRC_PREFIX_SANTIZE env var #165

wants to merge 2 commits into from

Conversation

ShootingKing-AM
Copy link

@ShootingKing-AM ShootingKing-AM commented Oct 30, 2022 •
edited
Loading

@ShootingKing-AM
impl OPENSSL_SRC_PREFIX_SANTIZE env var
6fd03a9 
- Sanitize path forcefully based on env var
- Dump some helpful build info when build fails
@ShootingKing-AM
typo
428720f
@alexcrichton
Copy link
Owner

Thanks for this PR, but is there a need for this to be an env var? Can this be automatically detected when this sanitization on Windows is required?

@ShootingKing-AM
Copy link
Author

ShootingKing-AM commented Nov 7, 2022 •
edited
Loading

Actually I also thought so, but i dont know all kinds of cases people use this crate in. So thought I wouldn't want to make any breaking changes.

Otherwise, we can enforce some consistency with --openssldir='s path's os type (i guess)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShootingKing-AM @alexcrichton