rebased v3 branch and removed all boost use and references #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does a better job of hiding implementation details and better prevents users from accidentially taking a dependency on the internal implementation details about how the Channel constructor works. This may be a breaking change for those that have used one of the existing constructors directly instead of one of the Create factory functions. This sets the groundwork for an upcoming API improvement of this interface.
Correct the verify_hostname parameter to be verify_hostname_and_peer, and update docs to reflect what its actually doing.
Instead of silently trying to connect without SSL, throw an exception to make the failure explicit.
Include was mistakenly removed due to bad merge, this restores that. Fixed: alanxz#265 Fixed: alanxz#266
v2.5.1 was release to correct a problem with install directories on Debian.
The intent is for this to replace the Channel::Create overload-set which is already hard to read, and even harder to expand. All new features needed as a part of this API will be added here, and the Create API will deprecated, and removed in v3.
These are being replaced by the Channel::Open function and all new functionality will be added there. The deprecated functions will be removed in a future version.
The latter is somewhat more efficient as it doesn't need to call strlen, thus its O(1) instead of O(N) on string size. Its also a pre-req for moving to boost::string_ref
We cannot just replace the entire `ret._flags` variable when setting certain message properties. We need to OR the variable with the corresponding flag. Otherwise, setting e.g. message expiration resets all the previously set flags, such as for priority or delivery mode. Many flags are ORed correctly (e.g. priority or delivery mode), but some are not. This commit fixes that. The bug that this commit fixes was introduced in commit 938b102.
Prepare for an easier transition to std::string_view.
Add instructions for building and installing SimpleAmqpClient dependancies.
Co-authored-by: Paul Morgan <pmorgan@friendmts.com>
This is to allow support for various C++17 features in use.
Which likely has better support for c++17.
Modern replacement is std::unique_ptr, mostly used just for PIMPL members.
= delete'ing the copy and assignment operator is the new hotness on how to specify that a class is noncopyable.
Un-boostify switching away from boost/cstdint.hpp
Un-boostify, and use initializer_lists.
Un-boostify and use std::to_string and std::stoul instead.
Un-boostify, apparently this was not used.
Un-boostify, apparently unused.
Un-boostify! Will eventually follow-up and move uses of std::shared_ptr to use std::unique_ptr, where there are API touch-points.
Unboostify!
Unboostify!
Unboostify!
Unboostify. Sadly no really good std library replacement here.
Un-boostify!
boost library is no longer needed as a dependency. Unboostify!
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.