Updated cmake for better portability #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateek9623
force-pushed
the
updated-cmake
branch
from
9a3433f
to
f2c1da5
Compare
prateek9623
force-pushed
the
updated-cmake
branch
13 times, most recently
from
76f7663
to
7363557
Compare
prateek9623
force-pushed
the
updated-cmake
branch
from
7363557
to
1d9d4bf
Compare
This is to allow support for various C++17 features in use.
Which likely has better support for c++17.
Modern replacement is std::unique_ptr, mostly used just for PIMPL members.
= delete'ing the copy and assignment operator is the new hotness on how to specify that a class is noncopyable.
Un-boostify switching away from boost/cstdint.hpp
Un-boostify, and use initializer_lists.
Un-boostify and use std::to_string and std::stoul instead.
Un-boostify, apparently this was not used.
Un-boostify, apparently unused.
Un-boostify! Will eventually follow-up and move uses of std::shared_ptr to use std::unique_ptr, where there are API touch-points.
Unboostify!
Unboostify!
Unboostify!
Unboostify. Sadly no really good std library replacement here.
Un-boostify!
boost library is no longer needed as a dependency. Unboostify!
prateek9623
force-pushed
the
updated-cmake
branch
from
1d9d4bf
to
bf31883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
Fixes #288
After this, we don't need "Rabbitmqc_LIBRARY", "Rabbitmqc_DIR variables". Now we only need 1 variable is needed i.e. "rabbitmq-c_ROOT"
And if vcpkg is used then no variable is needed