Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-190 | Test application registrations page details #38

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

Nbhtozcn
Copy link
Contributor

@Nbhtozcn Nbhtozcn commented Apr 3, 2024

Pull Request

Description:
Test cases added for Application Registrations Page

Related Issue:
Closes #AYS-190

Changes Made:
-Two test cases added for the application registrations page
-Two locators and two step definitions updated in the application registration filter case

Additional Information:
Add any additional information that might be relevant to reviewers.

Checklist

  • I have read and followed the contribution guidelines for this project.
  • I have added tests (if applicable).
  • All tests are passing.
  • I have updated the documentation (if necessary).

Reviewer Instructions

Provide instructions or guidelines for reviewers to follow when assessing your pull request.

Copy link
Contributor

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selamlar @Nbhtozcn hata alan testler var, bunları kontrol edebilir misin?

@Nbhtozcn
Copy link
Contributor Author

Nbhtozcn commented Apr 3, 2024

Selamlar @Nbhtozcn hata alan testler var, bunları kontrol edebilir misin?

Merhaba @agitrubard hata olan testler benim yaptıgım degisikliklere bağlı degil, oncesinde de hata alan testlerdi. Cagla uzerinde calistigi branchte bunlari cozuyor, o branch mergelenince burda da sorun kalmayacaktır diye düşünüyorum.

agitrubard
agitrubard previously approved these changes Apr 7, 2024
cagla88
cagla88 previously approved these changes Apr 16, 2024
@Nbhtozcn Nbhtozcn dismissed cagla88’s stale review April 16, 2024 13:36

The merge-base changed after approval.

cagla88
cagla88 previously approved these changes Apr 16, 2024
@cagla88 cagla88 requested a review from agitrubard April 16, 2024 13:42
@Nbhtozcn Nbhtozcn dismissed cagla88’s stale review April 16, 2024 13:42

The merge-base changed after approval.

@cagla88 cagla88 self-requested a review April 16, 2024 13:42
cagla88
cagla88 previously approved these changes Apr 16, 2024
@Nbhtozcn Nbhtozcn dismissed cagla88’s stale review April 16, 2024 13:52

The merge-base changed after approval.

cagla88
cagla88 previously approved these changes Apr 16, 2024
@Nbhtozcn Nbhtozcn dismissed cagla88’s stale review April 16, 2024 13:57

The merge-base changed after approval.

TekinMerve
TekinMerve previously approved these changes Apr 16, 2024
@Nbhtozcn Nbhtozcn dismissed TekinMerve’s stale review April 16, 2024 14:21

The merge-base changed after approval.

TekinMerve
TekinMerve previously approved these changes Apr 16, 2024
@Nbhtozcn Nbhtozcn dismissed TekinMerve’s stale review April 16, 2024 14:32

The merge-base changed after approval.

agitrubard
agitrubard previously approved these changes Apr 16, 2024
@Nbhtozcn Nbhtozcn dismissed agitrubard’s stale review April 16, 2024 17:25

The merge-base changed after approval.

@agitrubard agitrubard merged commit cca80e3 into main Apr 16, 2024
1 check passed
@agitrubard agitrubard deleted the test/AYS-190/applicants-list-page branch April 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants