Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvbit 1.7 #321

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Nvbit 1.7 #321

merged 4 commits into from
Aug 8, 2024

Conversation

barnes88
Copy link
Contributor

update tracer tool to use nvbit 1.7

@JRPan
Copy link
Collaborator

JRPan commented Jul 11, 2024

Wow you are fast

@JRPan JRPan mentioned this pull request Jul 12, 2024
Open
32 tasks
@JRPan JRPan added this to the v2.0 milestone Jul 12, 2024
@JRPan JRPan requested review from a team and christindbose and removed request for a team July 12, 2024 05:42
christindbose
christindbose previously approved these changes Jul 12, 2024
View reviewed changes
christindbose
christindbose reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@christindbose christindbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still allowed to use printf() in the instrument functions?

The following is from the NVbit release.

NVBit tools can no longer use syscalls in instrument functions, therefore printf() and assert() are no longer allowed in the injected functions

@christindbose christindbose dismissed their stale review July 12, 2024 16:52

Need confirmation on the usage of syscalls.

@barnes88
Copy link
Contributor Author

barnes88 commented Jul 12, 2024 •
edited
Loading

@christindbose I believe that is only referring to inside the injected function instrument_inst. You can confirm this is the case because they have assert() and printf() calls in the mem_trace.cu tool they release as an example with nvbit 1.7

christindbose
christindbose approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@christindbose christindbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, LGTM

@JRPan JRPan enabled auto-merge August 8, 2024 02:31
@JRPan JRPan added this pull request to the merge queue Aug 8, 2024
Merged via the queue into accel-sim:dev with commit 8d0785d Aug 8, 2024
4 checks passed
JRPan added a commit to JRPan/accel-sim-framework that referenced this pull request Sep 3, 2024
@barnes88 @JRPan
Nvbit 1.7 (accel-sim#321)
206fa2b 
* update tracer tool to nvbit 1.7

* format code

* add error message for nvcc < 11.7 if ARCH isn't defined

---------

Co-authored-by: JRPan <25518778+JRPan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christindbose christindbose christindbose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@barnes88 @JRPan @christindbose