MG-2441 - Add domain ID to API #2442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
force-pushed
the
domainid_api
branch
from
fe0647d
to
2bb9f74
Compare
dborovcanin
force-pushed
the
domainid_api
branch
from
06b04ea
to
9ca464e
Compare
nyagamunene
force-pushed
the
domainid_api
branch
4 times, most recently
from
10a4607
to
2e1e41b
Compare
dborovcanin
force-pushed
the
domainid_api
branch
from
6bf4323
to
7aa8a86
Compare
|
@nyagamunene Please make sure this is ready for review today. Also, please sign off your commits. |
No problem |
nyagamunene
force-pushed
the
domainid_api
branch
from
301b6f6
to
fb66b70
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
dborovcanin
requested changes
Oct 18, 2024
There was a problem hiding this comment.
@nyagamunene Please rebase. This is to be merged before #2409.
nyagamunene
force-pushed
the
domainid_api
branch
from
7719723
to
c2c2c61
Compare
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
…ion, readers and ws Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
nyagamunene
force-pushed
the
domainid_api
branch
from
4c4862e
to
02fa470
Compare
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
dborovcanin
requested changes
Oct 18, 2024
Comment on lines
+88
to
+100
| r.Get("/", otelhttp.NewHandler(kithttp.NewServer( | ||
| listClientsEndpoint(svc), | ||
| decodeListClients, | ||
| api.EncodeResponse, | ||
| opts..., | ||
| ), "list_clients").ServeHTTP) | ||
|
|
||
| r.Get("/search", otelhttp.NewHandler(kithttp.NewServer( | ||
| searchClientsEndpoint(svc), | ||
| decodeSearchClients, | ||
| api.EncodeResponse, | ||
| opts..., | ||
| ), "search_clients").ServeHTTP) |
There was a problem hiding this comment.
Remove duplicate handlers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: it add domain id when passing requests in the API layer.
What does this do?
It add domain id when passing requests in the API layer for users and things.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes.
Did you document any new/modified feature?
Yes
Notes