MG-2053 - Structure API Endpoints Based on Entities #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
api-refactor
branch
4 times, most recently
from
e676ad5
to
945ffdd
Compare
arvindh123
requested changes
Aug 21, 2024
There was a problem hiding this comment.
@felixgateru , I think list things is not in good shape, Could you for Domain member can able to list the things which they created ?
felixgateru
force-pushed
the
api-refactor
branch
2 times, most recently
from
2aaa9cc
to
10193b9
Compare
arvindh123
requested changes
Aug 29, 2024
things/service.go
Outdated
| } | ||
| pm.EntityType = auth.UserType | ||
| pm.EntityID = res.GetId() | ||
| return svc.listEntityThings(ctx, res.GetId(), res.GetDomainId(), auth.MembershipPermission, auth.DomainType, res.GetDomainId(), pm) |
There was a problem hiding this comment.
If domain is disabled , then this should not work for domain non administrator users. Please check this case
There was a problem hiding this comment.
I have checked this condition. When the domain is disabled only admins are able to list things
felixgateru
force-pushed
the
api-refactor
branch
2 times, most recently
from
8a7c8c3
to
f3fb6d0
Compare
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Signed-off-by: Arvindh <arvindh91@gmail.com> Co-authored-by: Arvindh <arvindh91@gmail.com> Co-authored-by: Arvindh <30824765+arvindh123@users.noreply.github.com> Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
dborovcanin
force-pushed
the
api-refactor
branch
from
f3fb6d0
to
8728d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it restructures endpoints based on entities to improve clarity and user experience.
What does this do?
This pr removes the following endpoints:
and replaces the functionlaity with list by entity option in list
domains,users,groups,channelsandthingsas documented in the api.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, relevant tests have been added and updated.
Did you document any new/modified feature?
Yes, the api documentation has been updated.
Notes