Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insufficient covariance detection #50

Merged

Conversation

steffahn
Copy link
Contributor

@steffahn steffahn commented Nov 9, 2023

This is sufficient to fix the soundness in issue #49, however I couldn’t quite understand how to bring the testing framework up to date correctly, especially the test-extra/invalid_manual part, so feel free to add a test yourself using the example from #49, either to this PR or as a follow-up :-)

@Voultapher
Copy link
Owner

Thanks for the fix. Let me look into the tests.

@Voultapher Voultapher force-pushed the fix_insufficient_covariance_detection branch from ba804d9 to e418be1 Compare November 9, 2023 17:58
@Voultapher Voultapher merged commit 2f34481 into Voultapher:main Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants