Skip to content

Commit

Permalink
Fix typo in args creation for VMAgent, VMAlert and VMSingle (#150)
Browse files Browse the repository at this point in the history
* Fix typo in args creation for VMAlert

* Fix typo in args creation for VMAlert and VMSingle
  • Loading branch information
jansyk13 authored Jan 22, 2021
1 parent 771605e commit 35bb2d7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion controllers/factory/vmagent.go
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func makeSpecForVMAgent(cr *victoriametricsv1beta1.VMAgent, c *config.BaseOperat
args = append(args, BuildRemoteWriteSettings(cr)...)

for arg, value := range cr.Spec.ExtraArgs {
args = append(args, fmt.Sprintf("--%s=%s", arg, value))
args = append(args, fmt.Sprintf("-%s=%s", arg, value))
}

args = append(args, fmt.Sprintf("-httpListenAddr=:%s", cr.Spec.Port))
Expand Down
2 changes: 1 addition & 1 deletion controllers/factory/vmalert.go
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ func vmAlertSpecGen(cr *victoriametricsv1beta1.VMAlert, c *config.BaseOperatorCo
confReloadArgs = append(confReloadArgs, fmt.Sprintf("-volume-dir=%s", path.Join(vmAlertConfigDir, cm)))
}
for arg, value := range cr.Spec.ExtraArgs {
args = append(args, fmt.Sprintf("--%s=%s", arg, value))
args = append(args, fmt.Sprintf("-%s=%s", arg, value))
}

args = append(args, fmt.Sprintf("-httpListenAddr=:%s", cr.Spec.Port))
Expand Down
4 changes: 2 additions & 2 deletions controllers/factory/vmsingle.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ func makeSpecForVMSingle(cr *victoriametricsv1beta1.VMSingle, c *config.BaseOper
}

for arg, value := range cr.Spec.ExtraArgs {
args = append(args, fmt.Sprintf("--%s=%s", arg, value))
args = append(args, fmt.Sprintf("-%s=%s", arg, value))
}

args = append(args, fmt.Sprintf("-httpListenAddr=:%s", cr.Spec.Port))
Expand Down Expand Up @@ -516,7 +516,7 @@ func makeSpecForVMBackuper(
args = append(args, fmt.Sprintf("-loggerFormat=%s", *cr.LogFormat))
}
for arg, value := range cr.ExtraArgs {
args = append(args, fmt.Sprintf("--%s=%s", arg, value))
args = append(args, fmt.Sprintf("-%s=%s", arg, value))
}

var ports []corev1.ContainerPort
Expand Down

0 comments on commit 35bb2d7

Please sign in to comment.