Created script to merge log files #53

siddhp1 · 2024-10-10T18:11:50Z

No description provided.

AshishA26

Reviewed

AshishA26 · 2024-10-11T03:50:57Z

logger/modules/log_file_merger.py

+
+def merge_log_files(log_file_directory: str) -> None:
+    """
+    Reads, sorts, and writes log files in the specified directory.


Add a line in the docstring saying what the parameter is

Xierumeng

Reviewed.

logger/modules/log_file_merger.py

logger/test_log_file_merger.py

Xierumeng

Reviewed.

logger/modules/log_file_merger.py

logger/test_log_file_merger.py

Xierumeng

Reviewed.

Note for reviewer: Check comments.

logger/modules/log_file_merger.py

logger/test_log_file_merger.py

Xierumeng

Reviewed.

Many comments here are redundant with the code or docstrings. Comments should convey information that the code doesn't already. For example:

Summary
Justification (of implementation, interface, etc.)

logger/modules/log_file_merger_helpers.py

logger/test_log_file_merger.py

…g run directories

siddhp1 added 2 commits October 10, 2024 14:08

Changed time format to 24 hour

7cf429f

Created script to merge log files

f5823aa

AshishA26 reviewed Oct 11, 2024

View reviewed changes

Improved docstrings

ee5d6cf

Xierumeng reviewed Oct 12, 2024

View reviewed changes

siddhp1 added 3 commits October 14, 2024 22:07

Separated logic into multiple functions, switched to pathlib

da1864d

Created tests for new functions

8093ef1

Fixed an issue where read test fails due to ordering of entries

9127984

Xierumeng reviewed Oct 16, 2024

View reviewed changes

siddhp1 added 3 commits October 16, 2024 22:59

Moved helper functions into separate file

5d30b73

Switched to tmp_path and added tests for edge cases

a369988

Fixed implicit concatenation issue in dummy log fixture

5b0936a

Xierumeng reviewed Oct 18, 2024

View reviewed changes

siddhp1 added 2 commits October 19, 2024 12:31

Added argument parsing to specify log directory to merge

19183e5

Added tests for new features and edge cases

16214f1

Xierumeng reviewed Oct 19, 2024

View reviewed changes

siddhp1 added 2 commits October 20, 2024 18:31

Added override argument, modified script to merge log files in all lo…

18595ae

…g run directories

Added tests for new function

88876ca

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created script to merge log files #53

Created script to merge log files #53

siddhp1 commented Oct 10, 2024

AshishA26 left a comment

AshishA26 Oct 11, 2024

Xierumeng left a comment

Xierumeng left a comment

Xierumeng left a comment

Xierumeng left a comment •

edited

Loading

Created script to merge log files #53

Are you sure you want to change the base?

Created script to merge log files #53

Conversation

siddhp1 commented Oct 10, 2024

AshishA26 left a comment

Choose a reason for hiding this comment

AshishA26 Oct 11, 2024

Choose a reason for hiding this comment

Xierumeng left a comment

Choose a reason for hiding this comment

Xierumeng left a comment

Choose a reason for hiding this comment

Xierumeng left a comment

Choose a reason for hiding this comment

Xierumeng left a comment • edited Loading

Choose a reason for hiding this comment

Xierumeng left a comment •

edited

Loading