Created download_commands function in flight_controller.py #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronWang04
requested changes
Jul 19, 2024
mavlink/modules/flight_controller.py
Outdated
| return [] | ||
| except ConnectionResetError: | ||
| print("ERROR: Connection with drone reset. Unable to download commands.") | ||
| return [] |
There was a problem hiding this comment.
add an empty blank line at the bottom of file (good convention)
mavlink/modules/flight_controller.py
Outdated
| command_sequence.download() | ||
| command_sequence.wait_ready() | ||
| commands = list(command_sequence) | ||
| return commands |
There was a problem hiding this comment.
you should return whether the operation was successful with a bool
so the function should return tuple[bool, List[dronekit.Command]]
mavlink/test_flight_controller.py
Outdated
| @@ -47,6 +47,15 @@ def main() -> int: | |||
|
|
|||
| time.sleep(DELAY_TIME) | |||
|
|
|||
| # Download and print commands | |||
| commands = controller.download_commands() | |||
There was a problem hiding this comment.
don't forget to change here when you change the return types!
AaronWang04
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.