correct overgeneration consumption for controllable modules #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(-1 * remaining_load) should be greate than (max_consumption) to exceed the modules consumption.
ahalev
approved these changes
Feb 28, 2023
|
Good catch, thanks. |
ahalev
requested review from
den-run-ai and
ahalev
and removed request for
ahalev
ahalev
approved these changes
Mar 2, 2023
|
Need to add test coverage: #232 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while working with your project and analyzing your code, I stumbled accross an misscalculation if the provided energy exceeds the load. I think you have misplaced the relational operator here. First tests show that the miscalculation is resolved with this change.
(-1 * remaining_load) should be greate than (max_consumption) to exceed the modules consumption
Best regards ;)
📚 Documentation preview 📚: https://pymgrid--231.org.readthedocs.build/en/231/