Fix: Create QEMU VMs directly in a configured Pool #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reintroduced Pool for maptoAPI (required for creating a VM within a Pool) - Removed step to add to Pool after creating of a VM (errors `500 already a member of pool` when Pool added to maptoAPI) - Added tests for maptoAPI for Pool
|
@mpywell didn't know setting the pool during create would create it in the pool, expected it to be something with the url. That probably how this bug slipped in to begin with. The Not sure if the pool property may be set in the api when updating the vm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
500 already a member of poolwhen Pool added to maptoAPI)Closes #366