Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md #351

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix README.md #351

merged 2 commits into from
Aug 19, 2024

Conversation

OidaTiftla
Copy link
Contributor

I noticed the README.md seems some kind of outdated.

I tried to update the portions I could test.

  • createQemu JSON Sample
  • cloneQemu JSON Sample
  • cloneQemu cloud-init JSON Sample

What I could not test in the createQemu JSON Sample:

  • needed to remove the rng0 section:
    • error creating VM: 500 only root can set 'rng0' config
  • needed to remove the usb0 section:
    • error creating VM: 500 only root can set 'usb0' config for real devices
  • needed to remove the network section:
    • error creating VM: 500 no sdn vnet ID specified
  • the disk section did not throw any errors, but the created VM also did not have the specified disk, maybe because I did not have a storage_type as dir configured?

I hope this helps the project. And if there is anything I can improve in this PR, I will appreciate your feedback.

- Fix description
- Fix memory
- Fix ostype
- Fix firewall
- Fix unknown backup in net config
- Extend and fix cloud-init
@OidaTiftla
Copy link
Contributor Author

OidaTiftla commented Aug 18, 2024

Hi @Tinyblargon, I don't know what is the correct workflow and if I need to mention you on this pull request.

Let me known if there's anything I need to modify so this can be merged.

Kind regards,
OidaTiftla

@Tinyblargon
Copy link
Collaborator

@OidaTiftla Thank you for your contribution. Didn't realize the README had fallen so out of date.

@Tinyblargon Tinyblargon merged commit 964a4a4 into Telmate:master Aug 19, 2024
5 checks passed
@OidaTiftla OidaTiftla deleted the fix-docu branch August 19, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants