feat: cache proxmox version in Client
#312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinyblargon
commented
Feb 7, 2024
|
|
||
| // Greater returns true if the version is greater than the other version. | ||
| func (v Version) Greater(other Version) bool { | ||
| return uint32(v.Major)*256*256+uint32(v.Minor)*256+uint32(v.Patch) > uint32(other.Major)*256*256+uint32(other.Minor)*256+uint32(other.Patch) |
There was a problem hiding this comment.
This is instead of multiple consecutive if statements. It needed a unit test anyways so might as well implement the most performant solution.
Minor 1 > Patch 255
Major 1 > (Minor 255 + Patch 255)
Tinyblargon
changed the title
Client
mleone87
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Version()to theClientstruct to return the cached PVE version and fetch it when we have no version yet.This does add a mutex to the
Clientif this becomes a performance issue we can fix it using channels, but this would be more complex and require a dispatch thread.closes #309