Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/firestore context #351

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

tomasliu-agora
Copy link
Collaborator

No description provided.

@@ -113,6 +114,9 @@ def start_event_loop(loop):
target=start_event_loop, args=(self.loop,))
self.thread.start()

r = Cmd.create("retrieve")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for auto retrieve history for the same channel if exists.
If you disconnect/connect again, or refresh the browser directly, the agent will make history kept.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently it only retrieves, and doesn't store, right?

@tomasliu-agora tomasliu-agora mentioned this pull request Oct 20, 2024
@wangyoucao577
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants