Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps3netsrv: Update to ps3netsrv 20240709 #6213

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

Hirador
Copy link
Contributor

@Hirador Hirador commented Aug 30, 2024

Update to ps3netsrv 20240709

Description

Fixes #

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

Update to v1.47.46h with ps3netsrv 20240709
@Hirador
Copy link
Contributor Author

Hirador commented Aug 30, 2024

@hgy59 @mreid-tt This is a minor revision update, if anything else is needed please let me know.
Other than that i have one question for you: is it possible to implement the field SPK_REV to accomodate letters?

@Hirador Hirador changed the title ps3netsrv-update ps3netsrv: Update to v1.47.46h with ps3netsrv 20240709 Aug 30, 2024
@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2024

@Hirador you must update cross/ps3netsrv too, otherwise nothing is updated.

@Hirador
Copy link
Contributor Author

Hirador commented Aug 30, 2024

@Hirador you must update cross/ps3netsrv too, otherwise nothing is updated.

Yes as i've said, this is a minor update, i've built everyting up before committing to GitHub (created an .spk for my architecture and tested it on my synology)

The version is still 1.47.46, only the revision changes so it won't affect PKG_VERS or any other variable in the Makefile inside cross/ps3netsrv, even the digests are not changing but the updates to the actual ps3netsrv are definitelly there.

@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2024

The version is still 1.47.46, only the revision changes so it won't affect PKG_VERS or any other variable in the Makefile inside cross/ps3netsrv, even the digests are not changing but the updates to the actual ps3netsrv are definitelly there.

Sorry, but I do not understand.
cross/ps3netsrv is the only dependency that is included in the spk.
If there is no other dependency (is there anything downloaded while building cross/ps3netsrv?) the spk will be binary the same.

@hgy59
Copy link
Contributor

hgy59 commented Aug 30, 2024

Other than that i have one question for you: is it possible to implement the field SPK_REV to accomodate letters?

No, this is not supported anymore since DSM 7 (see footnote 9) in #4524 (comment))

EDIT:
To specify the exact version in CHANGELOG as you do, is a good solution. We do the same for e.g. sslh package (https://synocommunity.com/package/sslh).

@Hirador
Copy link
Contributor Author

Hirador commented Aug 30, 2024

The version is still 1.47.46, only the revision changes so it won't affect PKG_VERS or any other variable in the Makefile inside cross/ps3netsrv, even the digests are not changing but the updates to the actual ps3netsrv are definitelly there.

Sorry, but I do not understand. cross/ps3netsrv is the only dependency that is included in the spk. If there is no other dependency (is there anything downloaded while building cross/ps3netsrv?) the spk will be binary the same.

I've made some research, i've actually found out where the problem is.
first yes, the source.tar.gz of the specified version is downloaded when building cross/ps3netsrv, and here is where the actual problem lies. The developer has actually updated everything up, but by appling a revison logic he may have missed the overall update of the actual source (which is what i use to download the package). I've reached out the developer, i will proceed with the update once we've figured it out.

Thanks for your patience

@Hirador Hirador changed the title ps3netsrv: Update to v1.47.46h with ps3netsrv 20240709 ps3netsrv: Update to ps3netsrv 20240709 Sep 4, 2024
@Hirador
Copy link
Contributor Author

Hirador commented Sep 4, 2024

@hgy59 @mreid-tt I've made some changes to the source fetching logic since the developer made a standalone repo dedicated for ps3netsrv, if anything else is needed please let me know.

@Hirador
Copy link
Contributor Author

Hirador commented Oct 18, 2024

@hgy59 waiting for you checks to proceed merging

spk/ps3netsrv/Makefile Outdated Show resolved Hide resolved
@hgy59 hgy59 merged commit 3e68981 into SynoCommunity:master Oct 18, 2024
15 checks passed
@hgy59 hgy59 added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/published Published and activated (may take up to 48h until visible in DSM package manager)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants