Skip to content

Commit

Permalink
Keep highestSequenceNrForPersistenceId journal query and comment the …
Browse files Browse the repository at this point in the history
…new one which uses journal_persistence_ids table
  • Loading branch information
tiagomota committed Oct 13, 2021
1 parent b1e97ff commit 0e95d77
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ trait BaseByteArrayJournalDao extends JournalDaoWithUpdates with BaseJournalDaoW

override def highestSequenceNr(persistenceId: String, fromSequenceNr: Long): Future[Long] =
for {
maybeHighestSeqNo <- db.run(queries.highestSequenceNrForPersistenceId(persistenceId).result.headOption)
maybeHighestSeqNo <- db.run(queries.highestSequenceNrForPersistenceId(persistenceId).result) //.headOption)
} yield maybeHighestSeqNo.getOrElse(0L)

override def messages(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ class JournalQueries(
.update(true)

private def _highestSequenceNrForPersistenceId(persistenceId: Rep[String]) = {
journalPersistenceIdsTable.filter(_.persistenceId === persistenceId).map(_.maxSequenceNumber).take(1)
journalTable.filter(_.persistenceId === persistenceId).map(_.sequenceNumber).max
// journalPersistenceIdsTable.filter(_.persistenceId === persistenceId).map(_.maxSequenceNumber).take(1)
}

private def _highestMarkedSequenceNrForPersistenceId(persistenceId: Rep[String]): Rep[Option[Long]] =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ class JournalQueriesTest extends BaseQueryTest {

it should "create SQL query for highestSequenceNrForPersistenceId" in withJournalQueries { queries =>
queries.highestSequenceNrForPersistenceId(
"aaa") shouldBeSQL """select "max_sequence_number" from "journal_persistence_ids" where "persistence_id" = ? limit 1"""
"aaa") shouldBeSQL """select max("sequence_number") from "journal" where "persistence_id" = ?"""
// queries.highestSequenceNrForPersistenceId("aaa") shouldBeSQL """select "max_sequence_number" from "journal_persistence_ids" where "persistence_id" = ? limit 1"""
}

it should "create SQL query for messagesQuery" in withJournalQueries { queries =>
Expand Down

0 comments on commit 0e95d77

Please sign in to comment.