Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return deleted resources object from submitChanges #442

Closed
wants to merge 7 commits into from

Conversation

kanikasharma97
Copy link
Contributor

This PR aims to enhance the handling of deleted resources during the submit changes process. Currently, when a resource is deleted, only a status code is returned from the API without providing any details regarding the deleted resource. This PR addresses this limitation by introducing improvements in two key scenarios:

  1. Handling Individual Resource Deletion:

    • Before submitting changes, the list of deleted resources is fetched in getRemovedResourcesObject method in FHIRModel.js
    • Upon successful deletion, it is ensured that the details of the deleted resources are returned along with the response.
  2. Handling Partial Deletion:

    • In cases where multiple resources are being deleted and only partial deletion is successful, the details of the resource(s) for which deletion was successful iS gathered through newly introduced method getsIdFromOperationOutcome located in FHIRUtility.js.
    • Only the details of the successfully deleted resource(s) are returned as part of oError.resources.

Copy link

cla-assistant bot commented Apr 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kanikasharma97
❌ Kanika Sharma


Kanika Sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

coverage: 95.714% (-0.03%) from 95.745%
when pulling e94dc8e on kanikasharma97:task/submitChanges
into 7345a2a on SAP:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants