Replaces JS with TS in client #3794
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmazacn
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal,
smahati and
amilewskaa
as code owners
ndricimrr
reviewed
Jul 2, 2024
client/luigi-client.d.ts
Outdated
| @@ -100,6 +101,21 @@ export declare interface UserSettings { | |||
| [key: string]: number | string | boolean; | |||
| } | |||
|
|
|||
| export declare interface CustomMessageData { | |||
There was a problem hiding this comment.
is this CustomMessageData used anywhere. I cannot find any usage of it anywhere on the repo. Would be nice to aim to only make JS-TS transfer with the most minimal changes possible in this PR. Adding new data types would have to be analysed first or be made in another follow up PR.
There was a problem hiding this comment.
It seems this is some unnecessary leftover - to be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #3791