feat(next-international): plurals with count 0 works with #zero
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QuiiBz
requested changes
Oct 4, 2023
| function getPluralKey(count: number) { | ||
| if (count === 0) return 'zero'; | ||
| return pluralRules.select(count); | ||
| } | ||
| const pluralRules = new Intl.PluralRules(context.locale); |
There was a problem hiding this comment.
Could you move this pluralRules variable before the new getPluralKey function? We try to keep things declared before they are used.
QuiiBz
changed the title
#zero
QuiiBz
requested changes
Oct 4, 2023
QuiiBz
added a commit
that referenced
this pull request
Oct 6, 2023
* feat(next-international): redirect default with `rewriteDefault` (#204) * feat(next-international): Static Rendering with loading for Client Components (#202) * feat(next-international): preserve search params (#207) * refactor: update client provider * feat: cache locale loading * feat: avoid triggering suspense with useParams * feat(next-international): plurals with count 0 works with `#zero` (#217) * make sure zero, one, two works * add plural key for only "zero" * move pluralRules * update docs * chore: bump version --------- Co-authored-by: Carl-Gerhard Lindesvärd <lindesvard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199