vmupdater: fix #9072

vmupdate/agent/entrypoint.py

@@ -56,6 +56,12 @@ def get_package_manager(os_data, log, log_handler, log_level, no_progress):
     If appropriate python package is not installed or `no_progress` is `True`
     cli based version is returned.
     """
+    requirements = {}
+    # plugins MUST be applied before import anything from package managers.
+    # in case of apt configuration is loaded on `import apt`.
+    for plugin in plugins.entrypoints:
+        plugin(os_data, log, requirements=requirements)
+
     if os_data["os_family"] == "Debian":
         try:
             from source.apt.apt_api import APT as PackageManager
@@ -82,10 +88,6 @@ def get_package_manager(os_data, log, log_handler, log_level, no_progress):
         raise NotImplementedError(
             "Only Debian, RedHat and ArchLinux based OS is supported.")
 
-    requirements = {}
-    for plugin in plugins.entrypoints:
-        plugin(os_data, log, requirements=requirements)
-
     pkg_mng = PackageManager(log_handler, log_level)
     pkg_mng.requirements = requirements
     return pkg_mng

vmupdate/agent/source/apt/apt_api.py

@@ -84,6 +84,8 @@ def upgrade_internal(self, remove_obsolete: bool) -> ProcessResult:
             Path(os.path.join(
                 apt_pkg.config.find_dir("Dir::Cache::Archives"), "partial")
             ).mkdir(parents=True, exist_ok=True)
+            apt_pkg.config.set('Dpkg::Options::', "--force-confdef")
+            apt_pkg.config.set('Dpkg::Options::', "--force-confold")
             self.log.debug("Committing upgrade...")
             self.apt_cache.commit(
                 self.progress.fetch_progress,

vmupdate/agent/source/apt/apt_cli.py

@@ -91,7 +91,12 @@ def get_action(self, remove_obsolete: bool) -> List[str]:
         """
         Return command `upgrade` or `dist-upgrade` if `remove_obsolete`.
         """
-        return ["dist-upgrade"] if remove_obsolete else ["upgrade"]
+        result = ["-y",
+                   "-o", 'Dpkg::Options::=--force-confdef',
+                   "-o", 'Dpkg::Options::=--force-confold'
+                  ]
+        result += ["dist-upgrade"] if remove_obsolete else ["upgrade"]
+        return result
 
     def clean(self) -> int:
         """

vmupdate/agent/source/common/package_manager.py

@@ -267,17 +267,15 @@ def get_packages(self) -> Dict[str, List[str]]:
 
     def get_action(self, remove_obsolete: bool) -> List[str]:
         """
-        Return command for upgrade or upgrade with removing obsolete packages.
+        Return command and options for upgrade with optional removing obsoletes.
         """
         raise NotImplementedError()
 
     def upgrade_internal(self, remove_obsolete: bool) -> ProcessResult:
         """
         Just run upgrade via CLI.
         """
-        cmd = [self.package_manager,
-               "--noconfirm" if self.package_manager == "pacman" else "-y",
-               *self.get_action(remove_obsolete)]
+        cmd = [self.package_manager, *self.get_action(remove_obsolete)]
 
         return self.run_cmd(cmd)
 

vmupdate/agent/source/dnf/dnf_cli.py

@@ -95,8 +95,8 @@ def get_action(self, remove_obsolete) -> List[str]:
         Disable or enforce obsolete flag in dnf/yum.
         """
         if remove_obsolete:
-            return ["--obsoletes", "upgrade"]
-        return ["--setopt=obsoletes=0",
+            return ["-y", "--obsoletes", "upgrade"]
+        return ["-y", "--setopt=obsoletes=0",
                 "upgrade" if self.package_manager == "dnf" else "update"]
 
     def clean(self) -> int:

vmupdate/agent/source/pacman/pacman_cli.py

@@ -65,7 +65,7 @@ def get_action(self, remove_obsolete) -> List[str]:
         """
         Pacman will handle obsoletions itself
         """
-        return ["-Syu"]
+        return ["--noconfirm", "-Syu"]
 
     def clean(self) -> int:
         """