Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BindGlobal more #24

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Use BindGlobal more #24

merged 1 commit into from
Dec 15, 2023

Conversation

fingolfin
Copy link
Contributor

The combo DeclareGlobalFunction plus InstallGlobalFunction exists
to deal with cases where functions must be declared before being used.
This is not the case here, and then using BindGlobal is simpler
and preferable.

The combo `DeclareGlobalFunction` plus `InstallGlobalFunction` exists
to deal with cases where functions must be declared before being used.
This is not the case here, and then using `BindGlobal` is simpler
and preferable.
Copy link
Member

@LeonidPryadko LeonidPryadko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fingolfin

@LeonidPryadko LeonidPryadko merged commit 3d8eab7 into QEC-pages:main Dec 15, 2023
3 checks passed
@fingolfin fingolfin deleted the mh/globals branch December 15, 2023 07:32
@LeonidPryadko
Copy link
Member

LeonidPryadko commented Jan 13, 2024

This replacement also resulted in documentation removal for each function from the manual created using AutoDoc package.
As a temporary solution, adding a commented line # DeclareGlobalFunction("FunctionName");
just before BindGlobal("FunctionName",...) causes documentation to reappear for FunctionName().
@fingolfin , I think this may be a bug in AutoDoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants