-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template structure simplification #317
Merged
Merged
Commits on Sep 4, 2024
-
♻️ Refactor the Template hierarchy
It has been a few weeks I am thinking about that, and a discussion with Kabir yesterday finally convinced me that refactoring the Template hierarchy was a good idea. The main reason for that refactor is the uneeded complexity of the old Template code: we only need to represent "simple" templates such as logical qubits and their sides. Being able to represent arbitrary templates using the ComposedTemplate class was nice, but not a requirement. With the need to query templates about their middle lines, sides, and likely other properties in the future that were not easily implementable (or even correctly defined) for all the possible ComposedTemplate instance, removing that intermediary seemed like a necessity. This (rather large, sorry) commit aims at greatly simplifying the Template-related module. The interfaces are left unchanged, which reduces by a lot the possibility of introducing errors with this refactor and reduces the number of changes.
Configuration menu - View commit details
-
Copy full SHA for 638ed9b - Browse repository at this point
Copy the full SHA 638ed9bView commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 89d00d1 - Browse repository at this point
Copy the full SHA 89d00d1View commit details
Commits on Sep 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa7abd8 - Browse repository at this point
Copy the full SHA aa7abd8View commit details -
Update src/tqec/templates/__init__.py
Co-authored-by: Yiming Zhang <61700160+inmzhang@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 3f8caa0 - Browse repository at this point
Copy the full SHA 3f8caa0View commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f31c51b - Browse repository at this point
Copy the full SHA f31c51bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1775337 - Browse repository at this point
Copy the full SHA 1775337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0724ecb - Browse repository at this point
Copy the full SHA 0724ecbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 846f2a2 - Browse repository at this point
Copy the full SHA 846f2a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de4674 - Browse repository at this point
Copy the full SHA 6de4674View commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 84002fa - Browse repository at this point
Copy the full SHA 84002faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68cc112 - Browse repository at this point
Copy the full SHA 68cc112View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ba20fb - Browse repository at this point
Copy the full SHA 5ba20fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for db26f81 - Browse repository at this point
Copy the full SHA db26f81View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf347f3 - Browse repository at this point
Copy the full SHA cf347f3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.