Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OOP-style Plaquette hierarchy to functional-style #183

Closed
nelimee opened this issue Mar 7, 2024 · 0 comments · Fixed by #203
Closed

Change OOP-style Plaquette hierarchy to functional-style #183

nelimee opened this issue Mar 7, 2024 · 0 comments · Fixed by #203
Assignees
@nelimee
Labels
backend Issue pertaining to the Python backend (tqec package) enhancement New feature or request, may not be in the task flow good first issue Good for newcomers help wanted Extra attention is needed refactor Requires major updates to code base

Comments

@nelimee
Copy link
Contributor

nelimee commented Mar 7, 2024

Is your feature request related to a problem? Please describe.
The problem is described in #179.

Describe the solution you'd like
There should be a unique Plaquette class with no child class. Each of the classes currently inheriting from Plaquette should be re-written in a functional-style.

Describe alternatives you've considered
See discussion in #179.
@nelimee nelimee added enhancement New feature or request, may not be in the task flow backend Issue pertaining to the Python backend (tqec package) refactor Requires major updates to code base labels Mar 7, 2024
@nelimee nelimee mentioned this issue Mar 21, 2024
Closed
@nelimee nelimee added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 21, 2024
@nelimee nelimee mentioned this issue Apr 10, 2024
Merged
@nelimee nelimee linked a pull request Apr 10, 2024 that will close this issue
Functional style plaquette #203
Merged
@nelimee nelimee self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelimee nelimee

Labels
backend Issue pertaining to the Python backend (tqec package) enhancement New feature or request, may not be in the task flow good first issue Good for newcomers help wanted Extra attention is needed refactor Requires major updates to code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Functional style plaquette nelimee/tqec
1 participant
@nelimee