Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional-style Plaquette #198

Closed
nelimee opened this issue Mar 21, 2024 · 1 comment
Closed

Functional-style Plaquette #198

nelimee opened this issue Mar 21, 2024 · 1 comment
Labels
backend Issue pertaining to the Python backend (tqec package) enhancement New feature or request, may not be in the task flow good first issue Good for newcomers help wanted Extra attention is needed refactor Requires major updates to code base

Comments

@nelimee
Copy link
Contributor

nelimee commented Mar 21, 2024

Is your feature request related to a problem? Please describe.
As discussed in #179, functional-style Plaquette is the preferred way.

Describe the solution you'd like
The Plaquette class should be made final and the actual classes that inherit from Plaquette should be replaced by functions.

Describe alternatives you've considered
Alternative: keep the the class hierarchy. Not the path picked in #179.
@nelimee nelimee added enhancement New feature or request, may not be in the task flow good first issue Good for newcomers help wanted Extra attention is needed backend Issue pertaining to the Python backend (tqec package) refactor Requires major updates to code base labels Mar 21, 2024
@nelimee
Copy link
Contributor Author

nelimee commented Mar 21, 2024

I forgot about #183, closing this as duplicate

@nelimee nelimee closed this as completed Mar 21, 2024
@nelimee nelimee mentioned this issue May 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Issue pertaining to the Python backend (tqec package) enhancement New feature or request, may not be in the task flow good first issue Good for newcomers help wanted Extra attention is needed refactor Requires major updates to code base
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelimee