Fix crash when trying to set a colour not from the list

Added a check and throws an error message now
Pxl-8 · Feb 5, 2020 · 5962c73 · 5962c73
1 parent f5e3019
commit 5962c73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/main/java/network/pxl8/colouredchat/chat/CommandSetColour.java b/src/main/java/network/pxl8/colouredchat/chat/CommandSetColour.java
@@ -24,6 +24,9 @@ private static int setColour(CommandSource source, TextFormatting colour) {
         if (!Configuration.ALLOW_CUSTOM.get()) {
             source.sendErrorMessage(new StringTextComponent("Command is disabled by config").applyTextStyle(TextFormatting.RED));
             return 0;
+        } else if (colour == null) {
+            source.sendErrorMessage(new StringTextComponent("Invalid colour specified").applyTextStyle(TextFormatting.RED));
+            return 0;
         } else {
             ColouredChat.getCap(source.getEntity()).ifPresent(colourData -> {
                 if (!colourData.getUsePlayerColour()) colourData.setUsePlayerColour(true);

diff --git a/src/main/java/network/pxl8/colouredchat/lib/LibColour.java b/src/main/java/network/pxl8/colouredchat/lib/LibColour.java
@@ -43,8 +43,8 @@ public static TextFormatting getColourFromName(String colour) {
             case("RED"): return TextFormatting.RED;
             case("LIGHT_PURPLE"): return TextFormatting.LIGHT_PURPLE;
             case("YELLOW"): return TextFormatting.YELLOW;
+            default: return null;
         }
-        return null;
     }
 
     public static TextFormatting randomFormattedColour() {