-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/메인 홈 페이지 작업 #53
Feat/메인 홈 페이지 작업 #53
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-vbuajanspi.chromatic.com/ |
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-ejlfhpzwqb.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성은님! 고생하셨습니다 ㅎㅎ
리뷰 확인 부탁드립니다~
{isOpenCategory && ( | ||
<div className='absolute right-0 top-[calc(100%-8px)] p-8 grid grid-cols-[300px_1fr] gap-8 bg-surface rounded-xl shadow-layer'> | ||
<Textfield | ||
value={category} | ||
onChange={handleChangeCategory} | ||
placeholder='새 카테고리 추가' | ||
isInvalid={isError} | ||
> | ||
<TextfieldInputWrapper> | ||
<TextfieldInput /> | ||
{isError && ( | ||
<Icon name='warningTriangle_f' className='w-16 h-16 text-icon-critical' /> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p4;
Category 추가 영역 밖에 클릭하면 닫히는 동작도 추가하면 좋을 것 같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅎㅎ TODO 에 있었군요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리구 이 Category 관련 모달(?) 나오는 것도 Component 화 해도 좋을 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵넵! 컴포넌트화 할 수 있는 부분들은 구조화해서 구분하겠습니다!
}, | ||
]; | ||
|
||
const FilterBox = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p4;
성은님!
Filter query Param으로 구현하신 이유가 있을까요?
state로 관리하는 것과 query Param으로 구현하는 방식 중 뭐가 좋을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
새로고침해도 유지되는 filter라고 생각해서 queryParam으로 구현했습니다! 명세서에도 확정된 부분은 아니라서 변경은 상관없을거 같아요!
만약 유지되야하는 상태라면 queryParam 사용이 좋을거 같아요!
src/components/FilterBox/index.tsx
Outdated
</button> | ||
<Divider direction='vertical' className='h-1/2 mx-2' /> | ||
<span className='cursor-pointer flex items-center gap-4 label-md text-text-minimal'> | ||
<Icon name='setting' className='w-20 h-20 ' /> 편집 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p9999;
style 맨 뒤 space 제거 부탁드립니당ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
계속 양 옆에 공백이 들어가 있네요...ㅠㅠ
<Button | ||
type='text' | ||
size='medium' | ||
onClick={() => updateQueryString('like-check', String(!isLikeChecked))} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
이쪽 like 쪽 클릭을 해도 동작을 안하는 것 같습니다!
확인 한번 부탁드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 확인해보겠습니다!
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-evhzisjbqv.chromatic.com/ |
📖 관련 문서
#52
✍🏻 변경사항:
🔍 확인할 목록
: 메인 페이지 정상 동작 확인
: 카테고리 등록 드롭 동작 확인
반응형 부분은 아직 반영못했습니다ㅠㅠ 이후 작업하면서 추가하면 좋을거 같아요
useSearchParam 사용하려면 suspense를 사용해야 한다고 하더라구요. fallback 컴포넌트도 추후에 추가해야할거 같습니다!