-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Login 기능 구현 #44
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-luyrzyvhtd.chromatic.com/ |
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-mlgxwcivba.chromatic.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로그인 고생하셨습니다ㅠㅠ!!
export const GOOGLE_LOGIN_URL = process.env.NEXT_PUBLIC_GOOGLE_LOGIN_BASE_URL;
env가 없어서 로그인 테스트를 못해봤습니다ㅠㅠ
src/app/login/page.tsx
Outdated
return ( | ||
<div className='w-full h-full flex items-center justify-center flex-col'> | ||
<div className='flex flex-col gap-32 justify-center items-center w-360 mb-[26px]'> | ||
<Logo type='symbol' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
피그마에 full_logo로 되어 있는데 혹시 symbol로 해놓으신 이유가 있으실까요!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
login 피그마 나오기 전에 진행해서 제 마음대로 했었습니다!
ㅋㅋㅋ 바꿔놓을게요~
<br /> | ||
나만의 인사이트를 관리하세요 | ||
</span> | ||
<button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Button 컴포넌트에 type=outline과 같은 ui인거 같아서 공통 컴포넌트로 변경해도 괜찮을거 같아요!
|
||
return ( | ||
<div className='w-full h-full flex items-center justify-center flex-col'> | ||
<div className='flex flex-col gap-32 justify-center items-center w-360 mb-[26px]'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w-360이 반영이 안되는거 같습니다!
반응형까지 생각했을때 모바일 사이즈에서 ~375px에서 양옆에 padding이 없이 width 100%로 적용되어 있어서 기본 padding 추가하면 좋을거 같아요!
@@ -0,0 +1,9 @@ | |||
<svg width="209" height="50" viewBox="0 0 209 50" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width랑 height가 적용되서 size가 적용이 잘 안되는거 같아요!
그리고 Icon 사용할때 width, height로 사용하시나요!! 저는 className으로 적용하는거 같아서요 통일하면 좋을거 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width, height 삭제하는게 맞습니다!
body { | ||
color: rgb(var(--foreground-rgb)); | ||
background: (var(--background-start-rgb)); | ||
@layer base { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
폰트 추가 좋습니다!!
@@ -0,0 +1,26 @@ | |||
import _ from 'lodash'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 신기한 코드네요! 혹시 어떤 동작을 하는지 알 수 있을까요!??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이쪽에서는 api end point들을 모아놓으려고 합니다!!
@@ -0,0 +1,11 @@ | |||
import getConfig from 'next/config'; | |||
|
|||
export const getEnv = (envName: string, fallback: string = ''): string => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 유틸은 env가 있을경우에는 env를 리턴하고 없을 경우에 fallback을 리턴하는걸까요!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞습니다!
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-tydxwkwizs.chromatic.com/ |
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-joudauvzdj.chromatic.com/ |
🚀 Storybook 자동 배포 URL: https://6637bd73cba78215aa6e39fa-sochypsmce.chromatic.com/ |
📖 관련 문서
#39 closed
✍🏻 변경사항:
🔍 확인할 목록