Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Divider 컴포넌트 작업 #34

Merged
merged 1 commit into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions src/components/common/Divider/Divider.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import type { Meta, StoryObj } from '@storybook/react';
import Divider from '.';

// More on how to set up stories at: https://storybook.js.org/docs/writing-stories#default-export
const meta = {
title: 'Common/Divider',
component: Divider,
tags: ['autodocs'],
args: {
direction: 'vertical',
},
argTypes: {
direction: {
options: ['vertical', 'horizontal'],
control: { type: 'select' },
},
},
} satisfies Meta<typeof Divider>;

export default meta;
type Story = StoryObj<typeof meta>;

// More on writing stories with args: https://storybook.js.org/docs/writing-stories/args
export const Horizontal: Story = {
args: {},
render: () => {
return (
<div className='w-full'>
<Divider />
</div>
);
},
};

export const Vertical: Story = {
args: {},
render: () => {
return (
<div className='h-[300px]'>
<Divider direction='vertical' />
</div>
);
},
};
25 changes: 25 additions & 0 deletions src/components/common/Divider/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { cn } from '@/lib/utils';
import { cva } from 'class-variance-authority';

export interface IDivider {
direction?: 'vertical' | 'horizontal';
className?: string;
}

const Divider = ({ direction, className }: IDivider) => {
Copy link
Contributor

@hoongding hoongding May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rai-95 성은님! direction props 에 default 로 주는게 가독성 측면에서 좋을까요 cva 안에서 defaultVariants로 주는게 좋을까요?

return <div className={cn(className, dividerVariants({ direction }))} />;
};

export default Divider;

export const dividerVariants = cva(['bg-divide'], {
variants: {
direction: {
horizontal: 'w-full h-1',
vertical: 'h-full w-1',
},
},
defaultVariants: {
direction: 'horizontal',
},
});
Loading