-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Divider 컴포넌트 작업 #34
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import type { Meta, StoryObj } from '@storybook/react'; | ||
import Divider from '.'; | ||
|
||
// More on how to set up stories at: https://storybook.js.org/docs/writing-stories#default-export | ||
const meta = { | ||
title: 'Common/Divider', | ||
component: Divider, | ||
tags: ['autodocs'], | ||
args: { | ||
direction: 'vertical', | ||
}, | ||
argTypes: { | ||
direction: { | ||
options: ['vertical', 'horizontal'], | ||
control: { type: 'select' }, | ||
}, | ||
}, | ||
} satisfies Meta<typeof Divider>; | ||
|
||
export default meta; | ||
type Story = StoryObj<typeof meta>; | ||
|
||
// More on writing stories with args: https://storybook.js.org/docs/writing-stories/args | ||
export const Horizontal: Story = { | ||
args: {}, | ||
render: () => { | ||
return ( | ||
<div className='w-full'> | ||
<Divider /> | ||
</div> | ||
); | ||
}, | ||
}; | ||
|
||
export const Vertical: Story = { | ||
args: {}, | ||
render: () => { | ||
return ( | ||
<div className='h-[300px]'> | ||
<Divider direction='vertical' /> | ||
</div> | ||
); | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import { cn } from '@/lib/utils'; | ||
import { cva } from 'class-variance-authority'; | ||
|
||
export interface IDivider { | ||
direction?: 'vertical' | 'horizontal'; | ||
className?: string; | ||
} | ||
|
||
const Divider = ({ direction, className }: IDivider) => { | ||
return <div className={cn(className, dividerVariants({ direction }))} />; | ||
}; | ||
|
||
export default Divider; | ||
|
||
export const dividerVariants = cva(['bg-divide'], { | ||
variants: { | ||
direction: { | ||
horizontal: 'w-full h-1', | ||
vertical: 'h-full w-1', | ||
}, | ||
}, | ||
defaultVariants: { | ||
direction: 'horizontal', | ||
}, | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rai-95 성은님! direction props 에 default 로 주는게 가독성 측면에서 좋을까요 cva 안에서 defaultVariants로 주는게 좋을까요?