Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Feature/header type 3 #1872

Closed
wants to merge 8 commits into from
Closed

Conversation

harshvitra
Copy link
Collaborator

This is Header type 3 -

Test in Make a Pledge and Update pledge screens

Expected Behavior - Scroll up, stick the header, but make it smaller
Dont animate, just show header on menu when scroll is greater than x height or something.

.env Outdated Show resolved Hide resolved
.env Outdated Show resolved Hide resolved
@norbertschuler norbertschuler added the old-config version not using the new .env.develop instead of config/index.js.dist label Feb 19, 2020
@norbertschuler
Copy link
Collaborator

norbertschuler commented Feb 19, 2020

  • I have an issue on the German page to make a pledge as the German translation is too long. In the old version the title is cut while with this new patch the title is wrapped around and therefore overlapping the back arrow which therefore is not clickable any more:

Old:

Simulator Screen Shot - iPhone 11 - 2020-02-19 at 14 01 26

New:

Simulator Screen Shot - iPhone 11 - 2020-02-19 at 13 56 25

Maybe use „ellipsis“ for the title field. That’s how I know it from native Android projects.

@norbertschuler
Copy link
Collaborator

@harshvitra keep or dismiss this?

@norbertschuler norbertschuler removed Should we close this? old-config version not using the new .env.develop instead of config/index.js.dist labels Mar 19, 2020
@norbertschuler
Copy link
Collaborator

norbertschuler commented Mar 19, 2020

Also check the issue from the comment #1906 (comment) I repeat here:

Simulator Screen Shot - iPhone 11 - 2020-03-14 at 12 20 27

  • cut headline for making a pledge

Simulator Screen Shot - iPhone 11 - 2020-03-14 at 12 20 38

Copy link
Collaborator

@norbertschuler norbertschuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would request some design fixes for pledges as written in the comments.

@norbertschuler
Copy link
Collaborator

@harshvitra is this issue related to #1871 and will you continue to work on it?

@norbertschuler norbertschuler added the old react-native version using old react-native version <0.6.x label Sep 27, 2020
@norbertschuler norbertschuler marked this pull request as draft September 28, 2020 14:24
@harshvitra harshvitra closed this Dec 21, 2020
@harshvitra harshvitra deleted the feature/headerAnimationChange branch December 21, 2020 13:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
old react-native version using old react-native version <0.6.x Should we close this?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants