Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Loading indicator for long running (API) transaction missing #1837

Open
norbertschuler opened this issue Jan 21, 2020 · 6 comments
Open

Loading indicator for long running (API) transaction missing #1837

norbertschuler opened this issue Jan 21, 2020 · 6 comments
Labels
Android Issue happening in the Android app architecture dangling iOS Issue happening in the iOS app

Comments

@norbertschuler
Copy link
Collaborator

We seem to have lost our progress dialog (spinner) appearing in the native apps for longer transactions triggered with dispatch(setProgressModelState(true)); and stopped with dispatch(setProgressModelState(false));.

@norbertschuler norbertschuler added bug Something isn't working Android Issue happening in the Android app iOS Issue happening in the iOS app labels Jan 21, 2020
@sagararyal
Copy link
Member

@norbertschuler we will need to slowly build loading components when we need

It is possible Haider's pr made this change.

@norbertschuler
Copy link
Collaborator Author

It's about the removal of ProgressModal for the native apps in 1cf2f54#diff-cf05ef6bde501ba20c3718feb1d21b81, so that no loading indicator is displayed any more for long running API calls.

Bildschirmfoto 2020-01-24 um 11 44 34

@norbertschuler
Copy link
Collaborator Author

@sagararyal @haideralishah please check the above listed API requests to decide which (e.g. register trees) could need a process indicator for giving users feedback.

@norbertschuler
Copy link
Collaborator Author

  • The FAQ / Imprint / PrivacyPolicy screens still shows the old loading indicator:

Bildschirmfoto 2020-02-04 um 11 43 06

@norbertschuler
Copy link
Collaborator Author

norbertschuler commented Mar 24, 2020

Maybe instead showing the old loading indicator we want to add a loading indicator as we added on the button of the login or the register trees screen?

Simulator Screen Shot - iPhone 11 - 2020-03-24 at 09 33 56

This could be useful for e.g. the button on the registration screen as this request sometimes takes quite long and the user might think the app has crashed.

@norbertschuler norbertschuler changed the title Progress indicator for long running (API) transaction not working anymore Loading indicator for long running (API) transaction missing Mar 24, 2020
@norbertschuler norbertschuler removed the P1 label May 5, 2020
@norbertschuler
Copy link
Collaborator Author

Here is a list of currently integrated ActivityIndicator components and #2323 is going to integrate one more in the PrimaryButton component:

Bildschirmfoto 2020-05-09 um 16 12 48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Issue happening in the Android app architecture dangling iOS Issue happening in the iOS app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants