Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Parse tags inside of props #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

grebaldi
Copy link
Member

@grebaldi grebaldi commented Mar 8, 2018

This allows for tags inside of props:

renderer = afx`
    <ul>
        <Collection
            itemRenderer={
                <li>{item.label}</li>
            }
            />
    </ul>
`

@grebaldi grebaldi requested a review from mficzel March 8, 2018 17:59
Copy link
Member

@mficzel mficzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine by reading

@mficzel
Copy link
Member

mficzel commented Jul 17, 2018

If this is the way this is done in JSX then let us include this aswell.

@mficzel
Copy link
Member

mficzel commented Oct 9, 2018

I suggest to rebase this on #15 once this is merged. I will gladly update afx to support this in total afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants