Skip to content

Commit

Permalink
fix: Fast signup confirmations (#33)
Browse files Browse the repository at this point in the history
* Update files with main

* Delete deprecated tests and update gemfile.lock

* Run bundle lock --add-platform x86_64-linux

* Update test string

* fix: Fast signup feature (#34)

* fix: Add specs for confirmation_codes_controller and fix confirmation token

* refactor: Typo in registration hide nickname example

* fix: Remove method skip from confirmation_codes_controller

* fix: Disable user confirmations when confirmation code (#35)

* fix: Disable user confirmations when confirmation code

* lint: Fix rubocop offenses

---------

Co-authored-by: Quentin Champenois <26109239+Quentinchampenois@users.noreply.github.com>
  • Loading branch information
paulinebessoles and Quentinchampenois authored Nov 16, 2023
1 parent 17ba59c commit bcb675c
Show file tree
Hide file tree
Showing 34 changed files with 876 additions and 429 deletions.
118 changes: 118 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
name: "[CI] Test"

on: "push"

env:
RUBY_VERSION: 3.0.2
SIMPLECOV: 1
CODECOV: 1

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 1
- uses: actions/setup-node@master
with:
node-version: ${{ env.NODE_VERSION }}
- run: npm ci
name: Install JS deps
- run: npm run lint
name: Lint JS files
- run: npm run stylelint
name: Lint SCSS files
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ env.RUBY_VERSION }}
bundler-cache: true
- run: bundle exec rubocop -P
name: Lint Ruby files
- run: bundle exec erblint app/**/*.erb
name: Lint ERB files
tests:
runs-on: ubuntu-latest

services:
postgres:
image: postgres:11
ports: ["5432:5432"]
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
env:
POSTGRES_PASSWORD: postgres
env:
DATABASE_USERNAME: postgres
DATABASE_PASSWORD: postgres
DATABASE_HOST: localhost
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 1
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ env.RUBY_VERSION }}
bundler-cache: true
- name: Setup Database
run: bundle exec rake test_app
- name: Run RSpec
run: bundle exec rspec --exclude-pattern "spec/system/**/*_spec.rb"
- uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v2-preview
if: always()
with:
name: screenshots
path: ./spec/decidim_dummy_app/tmp/screenshots
system-tests:
runs-on: ubuntu-latest
services:
postgres:
image: postgres:11
ports: ["5432:5432"]
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
env:
POSTGRES_PASSWORD: postgres
env:
DATABASE_USERNAME: postgres
DATABASE_PASSWORD: postgres
DATABASE_HOST: localhost
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 1
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ env.RUBY_VERSION }}
bundler-cache: true
- name: Setup Database
run: bundle exec rake test_app
- name: Run RSpec
run: bundle exec rspec spec/system
- uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/upload-artifact@v2-preview
if: always()
with:
name: screenshots
path: ./spec/decidim_dummy_app/tmp/screenshots
release:
if: "github.ref == 'refs/heads/master' || github.ref == 'refs/heads/main'"
needs: [lint, tests, system-tests]
runs-on: ubuntu-latest
steps:
- name: Publish gem
uses: OpenSourcePolitics/decidim-publish-gem-action@master
with:
rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}
github_token: ${{ secrets.GITHUB_TOKEN }}
42 changes: 0 additions & 42 deletions .github/workflows/lint.yml

This file was deleted.

70 changes: 0 additions & 70 deletions .github/workflows/test.yml

This file was deleted.

5 changes: 0 additions & 5 deletions .rubocop_ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,6 @@ AllCops:
# Otherwise we fallback to the oldest officially supported Ruby version (2.0).
TargetRubyVersion: 3.0

RSpec:
Patterns:
- "(?:^|/)spec/"
- "(?:^|/)test/"

# Indent private/protected/public as deep as method definitions
Layout/AccessModifierIndentation:
EnforcedStyle: indent
Expand Down
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.1
3.0.2
4 changes: 0 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,3 @@ group :development do
gem "spring-watcher-listen", "~> 2.0"
gem "web-console"
end

group :test do
gem "codecov", require: false
end
Loading

0 comments on commit bcb675c

Please sign in to comment.