Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose Elastic Authentication capabilities #256

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

Enquier
Copy link
Contributor

@Enquier Enquier commented Jan 3, 2024

This is a small update which should detect if you are using authentication for elastic connection and use it.

HuiJun

This comment was marked as outdated.

Copy link
Collaborator

@HuiJun HuiJun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you either need to add a null check, to handle cases when the property is not set, or uncomment the property below to avoid the NPE on startup since you're calling isEmpty() on a null.

Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@dlamoris dlamoris merged commit 4e4e858 into develop Feb 13, 2024
4 of 5 checks passed
@dlamoris dlamoris deleted the feature/elasticAuth branch March 12, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants