Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistence refactor #235

Closed
wants to merge 19 commits into from

Conversation

BA-MBSE
Copy link
Collaborator

@BA-MBSE BA-MBSE commented Mar 17, 2023

This PR decouples the federated (ES + PG) persistence layer from the Controller and Service layers, and replaces it with a unified persistence interface layer. Provided is a rehost of the ES + PG persistence layer as an implementation of the unified persistence layer (federatedpersistence).

Decoupled view controller from cameo module, added view module.

Added msosa module as schema for 2021x + MagicDraw Schema

Added oauth module

…ers.

Introduces a unified persistence layer interface with a federated implementation.
Added msosa, view, and oauth modules
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

return false;
}
} catch (ParseException e) {
logger.info("date parse exception: {} {}", jsonModified, existingModified);

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
This log entry depends on a
user-provided value
.
@BA-MBSE
Copy link
Collaborator Author

BA-MBSE commented Apr 5, 2023

@HuiJun How do you want to handle all of the "This log entry depends on a user defined value." errors?

@BA-MBSE BA-MBSE self-assigned this Apr 6, 2023
@BA-MBSE BA-MBSE marked this pull request as ready for review April 18, 2023 17:09
@BA-MBSE BA-MBSE requested review from HuiJun and dlamoris April 18, 2023 17:09
@HuiJun
Copy link
Collaborator

HuiJun commented May 16, 2023

@BA-MBSE I think the play here is to ignore them for now, with a note to fix before the next release.

Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 154 Code Smells

No Coverage information No Coverage information
4.6% 4.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@HuiJun HuiJun changed the base branch from develop to reconcile/openmbee_boeing February 7, 2024 01:55
@HuiJun HuiJun changed the base branch from reconcile/openmbee_boeing to develop February 7, 2024 01:56
@HuiJun HuiJun changed the base branch from develop to reconcile/openmbee_boeing February 7, 2024 03:38
@HuiJun HuiJun changed the base branch from reconcile/openmbee_boeing to develop February 7, 2024 04:22
@dlamoris
Copy link
Collaborator

branch was pushed to main repo, see #259

@dlamoris dlamoris closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants