-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i.eodag: remove pandas dependency and save results in json/geojson files #1104
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3d7fc8a
Add sorting with ingestiondate and cloudcover
HamedElgizery 0492e66
Change filters to eodag crunch
HamedElgizery 46ba518
Remove pandas dependency
HamedElgizery 08312e8
Add minimum_overlap option
HamedElgizery 2e82fce
Refactor messages
HamedElgizery 6ea3795
Remove duplicates
HamedElgizery 8229e48
Update manual
HamedElgizery 0e1f405
Add filtering by date
HamedElgizery 00c3b40
Add docstrings
HamedElgizery 72cfdc9
Merge branch 'grass8' into eodag_filter_sort
HamedElgizery 01d5a76
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery 1c4fdbb
Merge branch 'grass8' into eodag_filter_sort
echoix e3569ca
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery 7983e0e
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery e017d2c
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery c6fd7eb
Remove exclusive relation between area_relation and minimum_overlap
HamedElgizery 362769f
Add optional timezone to start and end options, all dates/time are co…
HamedElgizery ebc9884
Limit order to a single value asc or desc, instead of an order value …
HamedElgizery 66e84c7
Fix ingestiondate to be publicationDate instead of startTimeAscending…
HamedElgizery 2e06408
Add JSON output format and save to json/geojson files options
HamedElgizery a0df73a
Update src/imagery/i.eodag/i.eodag.html
HamedElgizery 88b31ae
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery a08eceb
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery 592f0e4
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery e529aef
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery c1f391d
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery 7a10a7d
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery 4096a9a
Update src/imagery/i.eodag/i.eodag.html
HamedElgizery d1f91ee
Update src/imagery/i.eodag/i.eodag.html
HamedElgizery f4d313c
Update src/imagery/i.eodag/i.eodag.html
HamedElgizery 280c94b
Fix minimum_overlap description
HamedElgizery 40c8e06
Update src/imagery/i.eodag/i.eodag.py
HamedElgizery 1ffa680
Update i.eodag.py
HamedElgizery 7934454
Update i.eodag.html
HamedElgizery b8b35f2
Reformat warning message setup_envrionment_variables function
HamedElgizery 23cfee6
Merge branch 'eodag_filter_sort' of github.com:HamedElgizery/grass-ad…
HamedElgizery 6d99e7f
Change ingestionDate to be startTimeFromAscendingNode
HamedElgizery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example or functionality does not make sense to me. If users provides a file with IDs is because they already did the search and filtering and they want to download the scenes found (i.e. IDs in the file). I cannot imagine to provide a text file with IDs and eodag doing a reverse search and filter... Is that what it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it takes the text file with a list of IDs, search for the scenes that is associated with each ID, and then it filters these founded scenes to make sure all of them satisfies the rest of the parameters.
I think a use case would be, if for example, a user did a general search (i.e. without setting the cloud coverage percentage), and then they want to pick scenes from this list of products with a certain cloud coverage percentage...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyways IMO, I can imagine that in most use cases products found by searching can be saved as a geojson file, and that geojson file can later be parsed by the module again. What is good about these geojson files, is that you don't need to do the searching again, as you already have the products ready to be downloaded after parsing the geojson file.
For reference: https://eodag.readthedocs.io/en/stable/notebooks/api_user_guide/5_serialize_deserialize.html?highlight=serialize
And for the text files it would just be a collection of IDs that is collected apart of the i.eodag module, and instead of typing them manually by hand in the shell they are just written in a text file... That is how I think it could be optimally used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HamedElgizery ok your explanation could make sense for me, Your idea it is not a common behaviour, people usually look for the data and later they download them. @veroandreo what do you think?
This seems the last open point before accept the pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm at a eodag workshop in FOSS4G, and now I see the potential utility of this. @HamedElgizery is this similar to what they do with the crunch functionality, that it filters a search object?
In any case, I think this can be merged.