Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch ocrd_page_generateds for automatic inheritance #700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

patch ocrd_page_generateds for automatic inheritance #700

wants to merge 2 commits into from

Conversation

bertsky
Copy link
Collaborator

@bertsky bertsky commented Jun 30, 2021

Fix #698

@bertsky bertsky requested a review from kba June 30, 2021 17:02
@bertsky bertsky force-pushed the ocrd-page-patch-inheritance branch from f88421e to ba88aee Compare June 30, 2021 22:59
kba
kba approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and patch applies fine. Proper support for inheritance of TextStyles will make life easier for e.g. the font recognition project. Any reason not to include in the next release together with #744 and #753?

@bertsky
Copy link
Collaborator Author

bertsky commented Dec 6, 2021

Any reason not to include in the next release together with #744 and #753?

Just to differentiate purely technical changes (the other PRs) from functional ones / new behaviour such as this. But release as you see fit.

This was referenced Dec 7, 2021
Open
Merged
@kba
Copy link
Member

kba commented Dec 21, 2021

further discussion in bertsky#2

@bertsky bertsky mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OcrdPage: propagate inherited attributes and TextStyle
2 participants
@bertsky @kba