[16.0][FIX] spreadsheet_oca: Avoid to show dynamic cols when no cols selected #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosRoca13
force-pushed
the
16.0-IMP-spreadsheet_oca
branch
from
6a7f345
to
2ab419e
Compare
pedrobaeza
reviewed
Sep 19, 2024
Steps to reproduce the error: 1. Go to a pivot 2. Remove all groups of columns to set only the measure 3. Add the pivot to a spreadsheet with dynamic columns and a number of columns An error will be thrown
CarlosRoca13
force-pushed
the
16.0-IMP-spreadsheet_oca
branch
from
2ab419e
to
51279a6
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7d01872. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the error:
An error will be thrown
cc @Tecnativa TT50912
ping @pedrobaeza @chienandalu