[17.0][ADD]mute_notification_user_autosubscribe: Do not send notification to users autosubscribed through user_id field #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please avoid plurals in module names, and more in the middle of the name. That's food for constant typos. |
manuelregidor
force-pushed
the
17.0-add-mute_notifications_user_autosubscribe
branch
from
6a9a3d4
to
17dde9e
Compare
|
@pedrobaeza done |
manuelregidor
changed the title
|
@manuelregidor Could you adapt the commit and the PR names, considering the correct module name, please? |
manuelregidor
changed the title
…o users autosubscribed through user_id field
manuelregidor
force-pushed
the
17.0-add-mute_notifications_user_autosubscribe
branch
from
17dde9e
to
05d89e0
Compare
|
@HaraldPanten done |
|
Let's wait for @luis-ron 's functional review, then. |
|
@Tisho99 Could you review, please? |
|
This PR has the |
|
@pedrobaeza @etobella your point of view here would be nice. Could you give us a hand? THX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HaraldPanten @ValentinVinagre
@luis-ron Could you review, please?
T-6499