Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] mail_forward: new module to forward messages from the chatter #1455

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

carlos-lopez-tecnativa
Copy link

TT51020
@Tecnativa @pedrobaeza @chienandalu @victoralmau could you please review this

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we set a FW: prefix in de subject?

image

@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 15.0-add-mail_forward branch 2 times, most recently from f1cce86 to b61ff47 Compare October 2, 2024 14:59
@carlos-lopez-tecnativa
Copy link
Author

Should we set a FW: prefix in de subject?

I added the prefix similar to Gmail. Thanks for the observation.

image

@pedrobaeza pedrobaeza added this to the 15.0 milestone Oct 3, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and working. Is there any other FA icon that represents better the forwarding (double arrow?)

@chienandalu
Copy link
Member

Tested on runboat and working. Is there any other FA icon that represents better the forwarding (double arrow?)

It can be done with fa-stack. An example:

<span
t-elif="tracking['status'] === 'delivered'"
class="fa-stack mail_tracking_delivered mail_tracking_pointer"
>
<i
class="fa fa-check fa-stack-1x"
style="margin-left:1px"
role="img"
aria-label="Delivered Status Left Checkmark"
/>
<i
class="fa fa-check fa-inverse fa-stack-1x"
style="margin-left:-2px;"
role="img"
aria-label="Delivered Status Center Checkmark"
/>
<i
class="fa fa-check fa-stack-1x"
style="margin-left:-3px"
role="img"
aria-label="Delivered Status Right Checkmark"
/>
</span>

@carlos-lopez-tecnativa
Copy link
Author

Tested on runboat and working. Is there any other FA icon that represents better the forwarding (double arrow?)

It can be done with fa-stack. An example:

With your example, it looks like this
image

With fa-forward it looks like this. What do you think?

image

@chienandalu
Copy link
Member

I meant stacking your original arrows. Altough the fa-forward could fit

@pedrobaeza
Copy link
Member

I think stacking the arrow seems better

@carlos-lopez-tecnativa
Copy link
Author

I updated the icon, and it looks like this. What do you think?
image

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1455-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f0b133e into OCA:15.0 Oct 3, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 48c6002. Thanks a lot for contributing to OCA. ❤️

@carlos-lopez-tecnativa carlos-lopez-tecnativa deleted the 15.0-add-mail_forward branch October 3, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants