Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] mail_notification_custom_subject #1454

Merged
merged 25 commits into from
Oct 14, 2024

Conversation

edlopen
Copy link
Member

@edlopen edlopen commented Oct 1, 2024

Standard migration to v16.

@moduon MT-7401

@Shide @yajo @EmilioPascual @rafaelbn please review, if you can.

joao-p-marques and others added 23 commits October 1, 2024 12:57
…l notifications

This module allows you to specify templates to override the subject on the notification
emails sent by Odoo.

TT27191

Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-15.0/social-15.0-mail_notification_custom_subject
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/
… send messages

After installing the module, any user was required to have admin rights to be able to search across models.

This fix does just that search with sudo and returns back to non-sudo mode immediately after. This way, we don't need to increase permissions for everybody.

Tests now run unprivileged, to assert this problem never happens again.

@moduon MT-1644 MT-1645
Currently translated at 100.0% (21 of 21 strings)

Translation: social-15.0/social-15.0-mail_notification_custom_subject
Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/es/
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link

@EmilioPascual EmilioPascual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review code

@pedrobaeza pedrobaeza changed the title 16.0 mig mail notification custom subject [16.0][MIG] mail_notification_custom_subject Oct 2, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the pre-commit changes from the migration itself as stated in the migration guide

/ocabot migration mail_notification_custom_subject

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Oct 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 2, 2024
38 tasks
@edlopen edlopen force-pushed the 16.0-mig-mail_notification_custom_subject branch from 6bdb165 to b39e093 Compare October 14, 2024 10:51
@edlopen
Copy link
Member Author

edlopen commented Oct 14, 2024

@pedrobaeza done! Can you revise again please? Thank you!

@pedrobaeza
Copy link
Member

OK, more or less, although the README changes should happen in the migration one, but let's not block more:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1454-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ddc0e91 into OCA:16.0 Oct 14, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 47ec998. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-mig-mail_notification_custom_subject branch October 15, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.