Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mail_show_follower: Migration to 17.0 #1440

Open
wants to merge 43 commits into
base: 17.0
Choose a base branch
from

Conversation

ericchew87
Copy link

My company just started using Odoo in July of 2024. This is my attempt to port this OCA module which we want to utilize in version 17.0. One place I think needs work is the translations. I changed some text to be more concise but then realized afterwards it would mess up the translations doing this. I appreciate any tips on whether its worth making this change, or if I should revert the text to what was in 16.0.

Thank you!
Eric

ValentinVinagre and others added 30 commits September 11, 2024 14:45
Display CC according to notification_type
Currently translated at 100.0% (7 of 7 strings)

Translation: social-12.0/social-12.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_show_follower/fr/
As commented in OCA#788 the PR should be merged manually but we should update the version of the module as a minor update

cc @ValentinVinagre @eLBati @MiquelRForgeFlow @HaraldPanten
Co-authored-by: Miquel Raïch <miquel.raich@eficent.com>
Added settings to customize notification and translations to important parts of the message.

[FIX] Security fixes and simplified customization

Field `show_followers_partner_format` formatted with %(param)s
Removed CSS customizations

[FIX] README options

[FIX] Index.html configure

[FIX] Several changes

- Removed unnecesary properties on res_config_settings
- Markup safe on partner_format
- Use email_domain_extract instead own one
When using composer, doesn't include all recipients of the message on the notification.
In the highly improbable but actually possible and real world case that a partner has more than one user associated, this change makes the emails able to send.

@moduon MT-1634
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/
Currently translated at 62.5% (10 of 16 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/es/
Currently translated at 100.0% (16 of 16 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/es/
Currently translated at 25.0% (4 of 16 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
Currently translated at 37.5% (6 of 16 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
Currently translated at 100.0% (16 of 16 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
adrianojprado and others added 11 commits September 11, 2024 14:45
Currently translated at 100.0% (16 of 16 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/pt_BR/
This module aims to show the recipients of an email in the email header, but the previous implementation was not suitable for internal notes.

When **logging an internal note** with tagged users and/or partners, those specific recipients should be displayed
as well as the document's followers subscribed to this message subtype.

When **sending an email**, the recipients should be the document's followers.

This is achieved by using the union of `mail.mail`'s `recipient_ids` and `notified_partner_ids`.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/
Currently translated at 100.0% (17 of 17 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/pt_BR/
Currently translated at 100.0% (17 of 17 strings)

Translation: social-16.0/social-16.0-mail_show_follower
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
@ericchew87 ericchew87 mentioned this pull request Sep 11, 2024
30 tasks
@ericchew87
Copy link
Author

Files impacting translations have been reverted, this is ready for review.

Copy link

@chusamo chusamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.