Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mail_optional_follower_notification: Migration to 17.0 #1381

Merged

Conversation

jdidderen-nsi
Copy link

Superseeding #1303

adrienpeiffer and others added 30 commits June 4, 2024 09:08
* [ADD] Add mail_optional_follower_notifications module

* [CHG][mail_optional_follower_notifications] Readme.

* [IMP][mail_optional_follower_notifications] Code review.

* [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification

* [IMP][mail_optional_follower_notification] Review
…tify instead of notify_followers.

Without this commit, followers are NEVER notified when a message is directly posted on the tracker (without click to open the mail compose message form)
Currently translated at 100.0% (5 of 5 strings)

Translation: social-10.0/social-10.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/de/
Currently translated at 100.0% (5 of 5 strings)

Translation: social-10.0/social-10.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/pt/
Co-authored-by: Isabelle RICHARD <isabelle.richard@smile.fr>
Currently translated at 50.0% (2 of 4 strings)

Translation: social-14.0/social-14.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_optional_follower_notification/es/
oca-ci and others added 5 commits June 4, 2024 09:08
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-16.0/social-16.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/
Currently translated at 100.0% (4 of 4 strings)

Translation: social-16.0/social-16.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/
Currently translated at 100.0% (4 of 4 strings)

Translation: social-16.0/social-16.0-mail_optional_follower_notification
Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/pt_BR/
@pedrobaeza pedrobaeza changed the title [MIG] mail_optional_follower_notification: Migration to 17.0 [17.0][MIG] mail_optional_follower_notification: Migration to 17.0 Jun 4, 2024
@pedrobaeza
Copy link
Member

/ocabot migration mail_optional_follower_notification

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 4, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 4, 2024
30 tasks
@AndrzejGerasimukARCHIMEDES

hello
when we can expect that migration will be done?

@AndrzejGerasimukARCHIMEDES

@jdidderen-nsi @pedrobaeza Is there any possibility to migration this module to 17.0 ?

@pedrobaeza
Copy link
Member

You can start reviewing current migration to see if it's correct. OCA flows require to have two approvals (one of them being PSC).

Copy link

@maciej-wichowski maciej-wichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review 👍

@Paulius11
Copy link

What seems to be the issue here? The runboat/build status appears to be Pending.

@jdidderen-nsi jdidderen-nsi force-pushed the 17.0-mig-mail_optional_follower_notification branch from 0cbc6fc to 43e38fd Compare October 17, 2024 12:21
@jdidderen-nsi
Copy link
Author

@Paulius11 I forced the update. It's good to go now 👍

@Paulius11
Copy link

Do all tests need to pass for this to be merged?

@jdidderen-nsi
Copy link
Author

@OCA/social-maintainers Can you take a look at this PR and see if it can be merged ?

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1381-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3ed4400 into OCA:17.0 Oct 21, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 654ea12. Thanks a lot for contributing to OCA. ❤️

@jdidderen-nsi jdidderen-nsi deleted the 17.0-mig-mail_optional_follower_notification branch October 21, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.