-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] mail_optional_follower_notification: Migration to 17.0 #1381
[17.0][MIG] mail_optional_follower_notification: Migration to 17.0 #1381
Conversation
* [ADD] Add mail_optional_follower_notifications module * [CHG][mail_optional_follower_notifications] Readme. * [IMP][mail_optional_follower_notifications] Code review. * [CHG] Rename mail_optional_follower_notifications to mail_optional_follower_notification * [IMP][mail_optional_follower_notification] Review
…e res.partner and channel
…r_notification and mail_optional_autofollow
…tify instead of notify_followers. Without this commit, followers are NEVER notified when a message is directly posted on the tracker (without click to open the mail compose message form)
Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/de/
Currently translated at 100.0% (5 of 5 strings) Translation: social-10.0/social-10.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-10-0/social-10-0-mail_optional_follower_notification/pt/
Co-authored-by: Isabelle RICHARD <isabelle.richard@smile.fr>
Currently translated at 50.0% (2 of 4 strings) Translation: social-14.0/social-14.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_optional_follower_notification/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/it/
Currently translated at 100.0% (4 of 4 strings) Translation: social-16.0/social-16.0-mail_optional_follower_notification Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_optional_follower_notification/pt_BR/
/ocabot migration mail_optional_follower_notification |
hello |
@jdidderen-nsi @pedrobaeza Is there any possibility to migration this module to 17.0 ? |
You can start reviewing current migration to see if it's correct. OCA flows require to have two approvals (one of them being PSC). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional and code review 👍
What seems to be the issue here? The runboat/build status appears to be Pending. |
0cbc6fc
to
43e38fd
Compare
@Paulius11 I forced the update. It's good to go now 👍 |
Do all tests need to pass for this to be merged? |
@OCA/social-maintainers Can you take a look at this PR and see if it can be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 654ea12. Thanks a lot for contributing to OCA. ❤️ |
Superseeding #1303