[14.0][FIX] mail_activity_team: Manually keep user_id in sync with team_user_id
#1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbrunn
requested changes
Apr 22, 2024
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
…user_id` Ensure that the built-in `user_id` field value is in sync with our field `team_user_id` before triggering `create`, otherwise the framework will try to resolve the inverse value by itself and will call `write` before create has ended. That leads to multiple side effects like sending two assignment notifications.
ypapouin
force-pushed
the
14.0-fix-mail_activity_team_user-sync
branch
from
ef2c1f2
to
6a09208
Compare
hbrunn
approved these changes
Oct 8, 2024
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the built-in
user_idfield value is in sync with our fieldteam_user_idbefore triggeringcreate, otherwise the framework will try to resolve the inverse value by itself and will callwritebefore create has ended. That leads to multiple side effects like sending two assignment notifications.